Skip to content

Table and field dnd ordering #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 58 additions & 18 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
},
"dependencies": {
"@dbml/core": "^3.9.7-alpha.0",
"@dnd-kit/core": "^6.3.1",
"@dnd-kit/sortable": "^10.0.0",
"@dnd-kit/utilities": "^3.2.2",
"@douyinfe/semi-ui": "^2.77.1",
"@lexical/react": "^0.12.5",
"@monaco-editor/react": "^4.7.0",
Expand All @@ -29,6 +32,7 @@
"jspdf": "^3.0.1",
"jszip": "^3.10.1",
"lexical": "^0.12.5",
"nanoid": "^5.1.5",
"node-sql-parser": "^5.3.9",
"oracle-sql-parser": "^0.1.0",
"react": "^18.2.0",
Expand Down
64 changes: 37 additions & 27 deletions src/components/EditorCanvas/Canvas.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export default function Canvas() {
} = useSelect();
const [dragging, setDragging] = useState({
element: ObjectType.NONE,
id: -1,
id: null,
prevX: 0,
prevY: 0,
initialPositions: [],
Expand All @@ -73,8 +73,8 @@ export default function Canvas() {
});
const [grabOffset, setGrabOffset] = useState({ x: 0, y: 0 });
const [hoveredTable, setHoveredTable] = useState({
tableId: -1,
field: -2,
tableId: null,
fieldId: null,
});
const [panning, setPanning] = useState({
isPanning: false,
Expand Down Expand Up @@ -167,7 +167,7 @@ export default function Canvas() {
const getElement = (element) => {
switch (element.type) {
case ObjectType.TABLE:
return tables[element.id];
return tables.find((t) => t.id === element.id);
case ObjectType.AREA:
return areas[element.id];
case ObjectType.NOTE:
Expand Down Expand Up @@ -264,7 +264,7 @@ export default function Canvas() {
});
} else if (
dragging.element !== ObjectType.NONE &&
dragging.id >= 0 &&
dragging.id !== null &&
bulkSelectedElements.length
) {
const currentX = pointer.spaces.diagram.x + grabOffset.x;
Expand All @@ -274,9 +274,10 @@ export default function Canvas() {

for (const element of bulkSelectedElements) {
if (element.type === ObjectType.TABLE) {
const { x, y } = tables.find((e) => e.id === element.id);
updateTable(element.id, {
x: tables[element.id].x + deltaX,
y: tables[element.id].y + deltaY,
x: x + deltaX,
y: y + deltaY,
});
}
if (element.type === ObjectType.AREA) {
Expand Down Expand Up @@ -317,21 +318,21 @@ export default function Canvas() {
(panning.cursorStart.y - pointer.spaces.screen.y) / transform.zoom,
},
}));
} else if (dragging.element === ObjectType.TABLE && dragging.id >= 0) {
} else if (dragging.element === ObjectType.TABLE && dragging.id !== null) {
updateTable(dragging.id, {
x: pointer.spaces.diagram.x + grabOffset.x,
y: pointer.spaces.diagram.y + grabOffset.y,
});
} else if (
dragging.element === ObjectType.AREA &&
dragging.id >= 0 &&
dragging.id !== null &&
areaResize.id === -1
) {
updateArea(dragging.id, {
x: pointer.spaces.diagram.x + grabOffset.x,
y: pointer.spaces.diagram.y + grabOffset.y,
});
} else if (dragging.element === ObjectType.NOTE && dragging.id >= 0) {
} else if (dragging.element === ObjectType.NOTE && dragging.id !== null) {
updateNote(dragging.id, {
x: pointer.spaces.diagram.x + grabOffset.x,
y: pointer.spaces.diagram.y + grabOffset.y,
Expand Down Expand Up @@ -441,7 +442,10 @@ export default function Canvas() {
};

const didPan = () =>
!(transform.pan.x === panning.panStart.x && transform.pan.y === panning.panStart.y);
!(
transform.pan.x === panning.panStart.x &&
transform.pan.y === panning.panStart.y
);

/**
* @param {PointerEvent} e
Expand Down Expand Up @@ -503,7 +507,7 @@ export default function Canvas() {
}
setDragging({
element: ObjectType.NONE,
id: -1,
id: null,
prevX: 0,
prevY: 0,
initialPositions: [],
Expand Down Expand Up @@ -585,7 +589,7 @@ export default function Canvas() {
setPanning((old) => ({ ...old, isPanning: false }));
setDragging({
element: ObjectType.NONE,
id: -1,
id: null,
prevX: 0,
prevY: 0,
initialPositions: [],
Expand All @@ -594,34 +598,40 @@ export default function Canvas() {
};

const handleLinking = () => {
if (hoveredTable.tableId < 0) return;
if (hoveredTable.field < 0) return;
if (
!areFieldsCompatible(
database,
tables[linkingLine.startTableId].fields[linkingLine.startFieldId],
tables[hoveredTable.tableId].fields[hoveredTable.field],
)
) {
if (hoveredTable.tableId === null) return;
if (hoveredTable.fieldId === null) return;

const { fields: startTableFields, name: startTableName } = tables.find(
(t) => t.id === linkingLine.startTableId,
);
const { type: startType, name: startFieldName } = startTableFields.find(
(f) => f.id === linkingLine.startFieldId,
);
const { fields: endTableFields, name: endTableName } = tables.find(
(t) => t.id === hoveredTable.tableId,
);
const { type: endType } = endTableFields.find(
(f) => f.id === hoveredTable.fieldId,
);

if (!areFieldsCompatible(database, startType, endType)) {
Toast.info(t("cannot_connect"));
return;
}
if (
linkingLine.startTableId === hoveredTable.tableId &&
linkingLine.startFieldId === hoveredTable.field
linkingLine.startFieldId === hoveredTable.fieldId
)
return;

const newRelationship = {
...linkingLine,
endTableId: hoveredTable.tableId,
endFieldId: hoveredTable.field,
endFieldId: hoveredTable.fieldId,
cardinality: Cardinality.ONE_TO_ONE,
updateConstraint: Constraint.NONE,
deleteConstraint: Constraint.NONE,
name: `fk_${tables[linkingLine.startTableId].name}_${
tables[linkingLine.startTableId].fields[linkingLine.startFieldId].name
}_${tables[hoveredTable.tableId].name}`,
name: `fk_${startTableName}_${startFieldName}_${endTableName}`,
id: relationships.length,
};
delete newRelationship.startX;
Expand Down
33 changes: 18 additions & 15 deletions src/components/EditorCanvas/Relationship.jsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useRef } from "react";
import { useMemo, useRef } from "react";
import {
Cardinality,
darkBgTheme,
Expand All @@ -20,6 +20,22 @@ export default function Relationship({ data }) {
const { selectedElement, setSelectedElement } = useSelect();
const { t } = useTranslation();

const pathValues = useMemo(() => {
const startTable = tables.find((t) => t.id === data.startTableId);
const endTable = tables.find((t) => t.id === data.endTableId);

if (!startTable || !endTable) return null;

return {
startFieldIndex: startTable.fields.findIndex(
(f) => f.id === data.startFieldId,
),
endFieldIndex: endTable.fields.findIndex((f) => f.id === data.endFieldId),
startTable: { x: startTable.x, y: startTable.y },
endTable: { x: endTable.x, y: endTable.y },
};
}, [tables, data]);

const theme = localStorage.getItem("theme");

const pathRef = useRef();
Expand Down Expand Up @@ -106,20 +122,7 @@ export default function Relationship({ data }) {
<g className="select-none group" onDoubleClick={edit}>
<path
ref={pathRef}
d={calcPath(
{
...data,
startTable: {
x: tables[data.startTableId].x,
y: tables[data.startTableId].y,
},
endTable: {
x: tables[data.endTableId].x,
y: tables[data.endTableId].y,
},
},
settings.tableWidth,
)}
d={calcPath(pathValues, settings.tableWidth)}
stroke="gray"
className="group-hover:stroke-sky-700"
fill="none"
Expand Down
Loading