Skip to content

Color added to main data types #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

Conversation

Happy4Game
Copy link
Contributor

I added colors to the most used data types, replace "?" by NULL and use the font 'monospace'

image

#418

Copy link

vercel bot commented May 12, 2025

@Happy4Game is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented May 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drawdb ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2025 6:36pm

@IgelVV
Copy link

IgelVV commented May 13, 2025

NULL is more obvious than "?", but it takes more space — so I prefer "?".
But using colors is a great idea!

@1ilit 1ilit linked an issue May 13, 2025 that may be closed by this pull request
Copy link
Member

@1ilit 1ilit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Thanks for the PR

Left a few comments to address, let me know if you have any questions

Also please format the code, to keep things like quotation marks and indents consistent

Copy link
Member

@1ilit 1ilit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@1ilit 1ilit merged commit b7445e2 into drawdb-io:main May 13, 2025
4 checks passed
@Happy4Game Happy4Game deleted the color-data-type branch May 13, 2025 19:35
ewqazxc pushed a commit to ewqazxc/drawdb that referenced this pull request May 15, 2025
* Color added to main datatypes

* Add tailwind colors to all data types and display them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add colors to data types
3 participants