Fix: implement missing onOk handler to download migration zip#960
Merged
1ilit merged 2 commits intodrawdb-io:mainfrom Mar 26, 2026
Merged
Fix: implement missing onOk handler to download migration zip#9601ilit merged 2 commits intodrawdb-io:mainfrom
1ilit merged 2 commits intodrawdb-io:mainfrom
Conversation
Add handleConfirm function to generate and download the zip file using JSZip. Attach the handler to the onOk prop of the Modal. Resolves drawdb-io#956
|
@mdzpaulina is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #956
This PR fixes the bug where the "Confirm" button on the Migrations (Beta) modal was unresponsive, preventing users from downloading their generated SQL migration scripts.
Solution
The issue occurred because the Semi UI
<Modal>component was missing theonOkevent handler.To fix this:
JSZipandfile-saverinMigration.jsx.handleConfirmfunction that packages theup.sqlanddown.sqlscripts into a.zipblob and triggers the download.JSZip.default || JSZipinstantiation to ensure compatibility with Vite's module bundling and preventTypeError: JSZip is not a constructor.handleConfirmfunction to theonOkprop of the Modal.Evidence:
