Add support for generation 3 gateway in addition to generation 2.#9
Open
sdf-cnicorp wants to merge 26 commits intodrbrain:masterfrom
Open
Add support for generation 3 gateway in addition to generation 2.#9sdf-cnicorp wants to merge 26 commits intodrbrain:masterfrom
sdf-cnicorp wants to merge 26 commits intodrbrain:masterfrom
Conversation
…s' library for HTTP calls.
- Enhanced dialog for Set Shade Position to support both gen 2 and gen3. - Enhanced dialog for Configure Shade to allow manual creation. Dialog improvements. - Revised States to support gen 2 and 3. - Revised Plugin version to 2.0.
- Revise powerview.py to make some return values match the gen 3 version. - Powerveiw3.py is drop-in substitute for powerview.py that supports gen 3. - Revise ReadMe to include gen 3 and document shade capabilities.
…ed to read data from the hub but not make any changes or run any scenes. test_powerview3.py passes all tests, but test_powerview.py has not been checked completely since the test requires a hub with the matching generation.
…figuration option to specify what position info is shown in the device State column. Update shades states for all shades on a hub after an Action is run.
…ubs, so that both can be tested without using any hub hardware. Revised logging to support selecting what to log. Many minor tweaks.
…g. Fixed plugin as needed.
…the plugin's log folder.
…to consolidate output in fewer files. Fixed plugin as needed.
… is available. Also logging changes and general clean-up.
…ks to tests and supporting files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many changes to support both generations with the same plugin. For gen 3, added powerview3.py that provides the same support as powerview.py does for gen 2. Revised powerview.py where needed to make it return the same data as powerview3.py. Added new Action to stop a shade that is moving for gen 3 only. Changes to shade state values, dialog improvements, and improved input validation.
Two test files are included to test the two powerview files, but only the test for powerview3.py currently passes. The other test has not been completely debugged as it requires a gen2 hub. The tests will read data from the hub, but the HTTP Put function has been mocked to always return a success status, so that no changes are made to the hub or shades by the tests.