Skip to content

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Apr 25, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@jikkai jikkai requested review from Jocs and wzhudev as code owners April 25, 2025 13:18
Copy link

github-actions bot commented Apr 25, 2025

View Deployment

📑 Demo (React@19) Demo (React@16) 📚 Storybook
🔗 Preview link 🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Apr 25, 2025

Playwright test results

passed  25 passed

Details

stats  25 tests across 12 suites
duration  6 minutes, 5 seconds
commit  d10b659
info  For more information, see full report

Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 75 lines in your changes missing coverage. Please review.

Project coverage is 33.06%. Comparing base (a1c0225) to head (d10b659).

Files with missing lines Patch % Lines
.../src/views/components/context-menu/ContextMenu.tsx 0.00% 70 Missing ⚠️
...sign/src/components/dropdown-menu/DropdownMenu.tsx 0.00% 4 Missing ⚠️
...components/dropdown-menu/DropdownMenuPrimitive.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #5094      +/-   ##
==========================================
- Coverage   33.07%   33.06%   -0.02%     
==========================================
  Files        2716     2716              
  Lines      142002   142062      +60     
  Branches    31579    31598      +19     
==========================================
  Hits        46968    46968              
- Misses      95034    95094      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wzhudev
Copy link
Contributor

wzhudev commented Apr 27, 2025

image

Some context menu items duplicated.

@jikkai jikkai marked this pull request as draft April 27, 2025 02:13
@jikkai jikkai force-pushed the refactor/context-menu branch 2 times, most recently from 9fc3833 to 1f16e4e Compare April 27, 2025 02:49
@jikkai
Copy link
Member Author

jikkai commented Apr 27, 2025

image

Some context menu items duplicated.

The hidden and disabled props have not yet been implemented, so the PR has been temporarily converted to a draft.

@jikkai jikkai marked this pull request as ready for review April 27, 2025 04:10
Copy link
Contributor

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jikkai jikkai marked this pull request as draft April 27, 2025 11:31
@jikkai jikkai force-pushed the refactor/context-menu branch from 4df00d2 to d10b659 Compare April 27, 2025 12:10
@wzhudev
Copy link
Contributor

wzhudev commented May 3, 2025

Is this PR still relevant? @jikkai

@jikkai jikkai force-pushed the refactor/context-menu branch from d10b659 to e8d32d3 Compare May 8, 2025 12:28
@jikkai jikkai force-pushed the refactor/context-menu branch from e8d32d3 to 1464954 Compare May 8, 2025 12:30
@jikkai
Copy link
Member Author

jikkai commented Jun 9, 2025

Is this PR still relevant? @jikkai

Still alive. Actually, there are a few problems in the Univer Docs that I do not have the time to work on all of them now. 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants