fix(docs): keep cursor stable at document bounds - #7149
Merged
Conversation
View Deployment
🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪 |
Playwright test resultsDetails
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #7149 +/- ##
==========================================
+ Coverage 80.28% 80.35% +0.07%
==========================================
Files 2530 2530
Lines 152511 152757 +246
Branches 35320 35398 +78
==========================================
+ Hits 122444 122753 +309
+ Misses 30067 30004 -63 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
pnpm --filter @univerjs/docs-ui exec vitest run src/controllers/__tests__/doc-move-cursor.controller.spec.ts src/services/__tests__/doc-paragraph-menu.service.spec.ts src/services/selection/__tests__/selection-utils.spec.ts src/shortcuts/__tests__/cursor.shortcut.spec.ts src/menu/__tests__/context-menu.spec.ts- 5 files, 85 tests passedpnpm --filter @univerjs/docs-ui testwas also attempted and failed in unrelated existing view/dependency-loading tests, including missing@univerjs/icons/React module reads and React view assertions outside the changed files.