Skip to content

fix(docs): keep cursor stable at document bounds - #7149

Merged
DR-Univer merged 4 commits into
devfrom
codex/docs-cursor-table-selection
Jun 25, 2026
Merged

fix(docs): keep cursor stable at document bounds#7149
DR-Univer merged 4 commits into
devfrom
codex/docs-cursor-table-selection

Conversation

@DR-Univer

Copy link
Copy Markdown
Member

Summary

  • Keep doc cursor movement stable at document boundaries, including Ctrl/Cmd navigation paths.
  • Preserve paragraph menu/context menu registration needed by the cursor behavior.
  • Add focused coverage for cursor shortcuts, cursor movement, paragraph menu range handling, selection rect conversion, and context menu wiring.

Test Plan

  • pnpm --filter @univerjs/docs-ui exec vitest run src/controllers/__tests__/doc-move-cursor.controller.spec.ts src/services/__tests__/doc-paragraph-menu.service.spec.ts src/services/selection/__tests__/selection-utils.spec.ts src/shortcuts/__tests__/cursor.shortcut.spec.ts src/menu/__tests__/context-menu.spec.ts - 5 files, 85 tests passed
  • Note: full pnpm --filter @univerjs/docs-ui test was also attempted and failed in unrelated existing view/dependency-loading tests, including missing @univerjs/icons/React module reads and React view assertions outside the changed files.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

View Deployment

#28135277260

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

Playwright test results

passed  8 passed

Details

stats  8 tests across 3 suites
duration  3 minutes, 27 seconds
commit  7847ffa
info  For more information, see full report and artifacts

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.68421% with 80 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.35%. Comparing base (cdae784) to head (7847ffa).

Files with missing lines Patch % Lines
...s-ui/src/controllers/doc-move-cursor.controller.ts 71.32% 80 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #7149      +/-   ##
==========================================
+ Coverage   80.28%   80.35%   +0.07%     
==========================================
  Files        2530     2530              
  Lines      152511   152757     +246     
  Branches    35320    35398      +78     
==========================================
+ Hits       122444   122753     +309     
+ Misses      30067    30004      -63     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DR-Univer
DR-Univer merged commit e4c33e1 into dev Jun 25, 2026
17 checks passed
@DR-Univer
DR-Univer deleted the codex/docs-cursor-table-selection branch June 25, 2026 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant