Skip to content

feat(board): support explicit locale exports - #7150

Closed
DR-Univer wants to merge 6 commits into
devfrom
codex/board-support-design-exports
Closed

feat(board): support explicit locale exports#7150
DR-Univer wants to merge 6 commits into
devfrom
codex/board-support-design-exports

Conversation

@DR-Univer

Copy link
Copy Markdown
Member

Summary

  • add explicit locale publish exports for packages that opt out of wildcard exports
  • keep wildcard publish behavior unchanged by default
  • improve design Button asChild typing and Switch accessibility semantics for board UI controls

Why

The board packages in pro need stable explicit locale entrypoints during bundling and publishing. Board settings also rely on Univer design controls behaving like accessible switches while preserving existing visual behavior.

Validation

  • pnpm --filter @univerjs/design exec vitest run src/components/switch/__tests__/index.spec.tsx --reporter=verbose
  • pnpm exec vitest run common/shared/tsdown/utils/cleanup-pkg.spec.ts --reporter=verbose

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

View Deployment

#28117188747

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@DR-Univer DR-Univer changed the title [codex] support explicit locale exports feat(board): support explicit locale exports Jun 24, 2026
@DR-Univer
DR-Univer force-pushed the codex/board-support-design-exports branch from b04affa to a9de197 Compare June 24, 2026 17:24
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

Playwright test results

passed  8 passed

Details

stats  8 tests across 3 suites
duration  3 minutes, 34 seconds
commit  7ed15ce
info  For more information, see full report and artifacts

@DR-Univer
DR-Univer force-pushed the codex/board-support-design-exports branch from a9de197 to 7ed15ce Compare June 24, 2026 17:29
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.28%. Comparing base (cdae784) to head (7ed15ce).

Files with missing lines Patch % Lines
packages/design/src/components/button/Button.tsx 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #7150   +/-   ##
=======================================
  Coverage   80.28%   80.28%           
=======================================
  Files        2530     2530           
  Lines      152511   152525   +14     
  Branches    35320    35321    +1     
=======================================
+ Hits       122444   122456   +12     
- Misses      30067    30069    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread packages/design/src/components/button/Button.tsx Outdated
@DR-Univer
DR-Univer force-pushed the codex/board-support-design-exports branch from 7ed15ce to c906c31 Compare June 27, 2026 13:41
Comment thread packages/design/src/components/switch/Switch.tsx Outdated
@DR-Univer DR-Univer closed this Jul 3, 2026
@DR-Univer
DR-Univer deleted the codex/board-support-design-exports branch July 3, 2026 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants