feat(board): support explicit locale exports - #7150
Closed
DR-Univer wants to merge 6 commits into
Closed
Conversation
View Deployment
🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪 |
DR-Univer
force-pushed
the
codex/board-support-design-exports
branch
from
June 24, 2026 17:24
b04affa to
a9de197
Compare
Playwright test resultsDetails
|
DR-Univer
force-pushed
the
codex/board-support-design-exports
branch
from
June 24, 2026 17:29
a9de197 to
7ed15ce
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #7150 +/- ##
=======================================
Coverage 80.28% 80.28%
=======================================
Files 2530 2530
Lines 152511 152525 +14
Branches 35320 35321 +1
=======================================
+ Hits 122444 122456 +12
- Misses 30067 30069 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jikkai
requested changes
Jun 26, 2026
DR-Univer
force-pushed
the
codex/board-support-design-exports
branch
from
June 27, 2026 13:41
7ed15ce to
c906c31
Compare
jikkai
requested changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asChildtyping and Switch accessibility semantics for board UI controlsWhy
The board packages in pro need stable explicit locale entrypoints during bundling and publishing. Board settings also rely on Univer design controls behaving like accessible switches while preserving existing visual behavior.
Validation
pnpm --filter @univerjs/design exec vitest run src/components/switch/__tests__/index.spec.tsx --reporter=verbosepnpm exec vitest run common/shared/tsdown/utils/cleanup-pkg.spec.ts --reporter=verbose