dbt 1.9 migration#296
Merged
Merged
Conversation
99Lys
force-pushed
the
DX-99958-dbt-1.9-migration
branch
from
3ba2f3a to
6b9ae60
Compare
99Lys
force-pushed
the
DX-99958-dbt-1.9-migration
branch
from
bfa5c79 to
74a629c
Compare
99Lys
force-pushed
the
DX-99958-dbt-1.9-migration
branch
from
74a629c to
1e3c6c9
Compare
…ing a datetime value for dbt_valid_to for current records instead of NULL
99Lys
force-pushed
the
DX-99958-dbt-1.9-migration
branch
from
3f16685 to
d2d4ef5
Compare
99Lys
commented
Jun 27, 2025
99Lys
commented
Jun 27, 2025
99Lys
requested review from
bcmeireles,
howareyouman,
simonpannek and
valterfrancisco-dremio
99Lys
commented
Jun 27, 2025
99Lys
commented
Jun 27, 2025
|
@99Lys could you please add the changelog message about the migration? Thanks! |
howareyouman
reviewed
Jul 1, 2025
howareyouman
left a comment
howareyouman
left a comment
There was a problem hiding this comment.
Could you please add the test for the new behavior of snapshot macro?
The rest is great.
99Lys
force-pushed
the
DX-99958-dbt-1.9-migration
branch
from
9080518 to
512c36a
Compare
howareyouman
reviewed
Jul 2, 2025
howareyouman
previously approved these changes
Jul 3, 2025
howareyouman
left a comment
howareyouman
left a comment
There was a problem hiding this comment.
Thanks for your PR!
It would be awesome if we could clean TestSnapshotCheckColsDremio and TestSnapshotTimestampDremio test classes.
99Lys
force-pushed
the
DX-99958-dbt-1.9-migration
branch
from
a871537 to
ce99ea6
Compare
howareyouman
approved these changes
Jul 4, 2025
howareyouman
left a comment
howareyouman
left a comment
There was a problem hiding this comment.
I'm ok having duplication of tests from dbt-adapters, but at the same time, if it's possible to patch the problem there, we should do it.
valterfrancisco-dremio
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updating dbt-dremio to match dbt-core v1.9.0.
Description
Following Adapter Maintainers: Upgrading to dbt-core v1.9.0:
dbt_valid_tofor current records instead ofNULLhard_deletesconfig to add a metadata column if a record has been deleted (automatically inherited from dbt-adapters)unique_keyas a list (automatically inherited from dbt-adapters)Test Results
TestSnapshotDbtValidToCurrentDremio,TestSnapshotColumnNamesDremio,TestSnapshotColumnNamesFromDbtProjectDremioandTestSnapshotInvalidColumnNamesDremiotests for the snapshot improvementsChangelog