Enhance persist_docs.sql#299
Merged
Merged
Conversation
Enhances the persist docs functionality to wrap all yml info in a markdown format and then sends that through to the Dremio wiki. This enables additional metadata to be captured such as field level info.
|
|
99Lys
requested changes
Jul 16, 2025
Contributor
There was a problem hiding this comment.
Hi @rfeith2
Thank you for your contribution!
This enhancement looks good to me, however the respective tests need to be updated as well - as they were expecting only the model description.
Also please include a summary of your changes in the changelog.
add v1.9.1. version and persist doc enhancement
…sist_docs Update persist docs tests for new wiki format
99Lys
requested changes
Jul 22, 2025
99Lys
reviewed
Jul 23, 2025
updating version to 2 in _assert_view_wikis_and_tags_delete
rfeith2
commented
Jul 23, 2025
99Lys
previously approved these changes
Jul 24, 2025
99Lys
approved these changes
Jul 24, 2025
howareyouman
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhances the persist docs functionality to wrap all yml info in a markdown format and then sends that through to the Dremio wiki. This enables additional metadata to be captured such as field level info.
Description
Test Results
Tested locally on my dbt project and haven't run into any issues.
Changelog
Contributor License Agreement
Related Issue