Skip to content

Add Enterprise Catalog tests#307

Merged
99Lys merged 11 commits into
dremio:mainfrom
99Lys:DX-106034-enterprise-catalog-tests
Sep 1, 2025
Merged

Add Enterprise Catalog tests#307
99Lys merged 11 commits into
dremio:mainfrom
99Lys:DX-106034-enterprise-catalog-tests

Conversation

@99Lys
Copy link
Copy Markdown
Contributor

@99Lys 99Lys commented Aug 13, 2025

Summary

Add Enterprise Catalog related tests and adjustments.

Description

  • Added test profiles with Enterprise Catalog as storage option and respective tests → TestProfileTemplate and TestProfileValidation
  • Added test to confirm that twin strategy is not applied when Enterprise Catalog is used → TestTwinStrategyNotAppliedDremio
  • Updated expected failures

Test Results

All tests are passing/failing as expected

Changelog

  • Added a summary of what this PR accomplishes to CHANGELOG.md

Related Issue

#298

@99Lys 99Lys force-pushed the DX-106034-enterprise-catalog-tests branch 13 times, most recently from b5c2c0d to b31e886 Compare August 20, 2025 10:02
@99Lys 99Lys closed this Aug 20, 2025
@99Lys 99Lys force-pushed the DX-106034-enterprise-catalog-tests branch from b31e886 to e20e92c Compare August 20, 2025 10:06
@99Lys 99Lys reopened this Aug 20, 2025
@99Lys 99Lys force-pushed the DX-106034-enterprise-catalog-tests branch from a231859 to 02296e1 Compare August 20, 2025 11:45
@99Lys 99Lys force-pushed the DX-106034-enterprise-catalog-tests branch from 02296e1 to 0b3db8e Compare August 20, 2025 11:47
@99Lys 99Lys marked this pull request as ready for review August 20, 2025 13:06
@99Lys 99Lys changed the title Enterprise Catalog tests Add Enterprise Catalog tests Aug 20, 2025
Copy link
Copy Markdown
Member

@simonpannek simonpannek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Seems like you have two tests failing though...

Comment thread tests/functional/adapter/dremio_specific/test_twin_strategy.py Outdated
@99Lys 99Lys requested a review from simonpannek September 1, 2025 10:53
@99Lys 99Lys merged commit 5c60514 into dremio:main Sep 1, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants