Skip to content
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# dbt-dremio v1.10.1

## Changes

- Reenabled `object_storage_path` and `root_path` as config parameters.

# dbt-dremio v1.10.0

## Changes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ limitations under the License.*/
{% macro dremio__generate_schema_name(custom_schema_name, node) -%}
{%- set default_schema = target.schema if not is_datalake_node(node)
else target.root_path -%}
{%- set custom_schema_name = custom_schema_name if not is_datalake_node(node)
else node.config.root_path -%}
{{ generate_schema_name_impl(default_schema, custom_schema_name, node) }}
{%- endmacro %}

Expand Down
4 changes: 2 additions & 2 deletions dbt/include/dremio/profile_template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,13 @@ prompts:
hint: 'object storage source for seeds, tables, etc. [dbt alias: datalake]'
object_storage_path:
default: 'no_schema'
hint: 'object storage path [dbt alias: schema]'
hint: 'object storage path [dbt alias: root_path]'
dremio_space:
default: '@user'
hint: 'space for creating views [dbt alias: database]'
dremio_space_folder:
default: 'no_schema'
hint: 'dremio space folder [dbt alias: root_path]'
hint: 'dremio space folder [dbt alias: schema]'
threads:
hint: '1 or more'
type: 'int'
Expand Down
5 changes: 3 additions & 2 deletions tests/functional/adapter/dremio_specific/test_exact_search.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from dbt.tests.util import run_dbt, get_connection

from tests.utils.util import relation_from_name
from tests.fixtures.profiles import unique_schema, dbt_profile_data
Comment thread
99Lys marked this conversation as resolved.


class TestExactSearchEnabled:
Expand All @@ -12,7 +13,7 @@ def models(self):
"create_table.sql": """
{{ config(
materialized='table',
schema='schema') }}
root_path='schema') }}
select 1 as ilike
"""
}
Expand Down Expand Up @@ -117,4 +118,4 @@ def test_ilike_case_sensitive_list_relations_without_caching(self, project):
with get_connection(adapter):
columns = adapter.list_relations_without_caching(table_relation)

assert len(columns) == 1
assert len(columns) == 1
Loading
Loading