Added features for Nessie branch management#315
Open
lorepas wants to merge 1 commit into
Open
Conversation
|
lorenzop seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains code updates that enable branch management for Nessie source code.
Description
The changes made allowed us to specify two new configurations:
branch: allows you to specify a branch. If used in a materialized application, it creates the PDS on the specified branch (if the branch doesn't exist, it creates it first). If used in a VDS, however, it creates it from the PDS and the specified branch.nessie_ref: to be inserted in a materialized application. When present, it creates the new branch from the reference entered; otherwise, if the branch doesn't exist, it is created from main.Test Results
I performed the following tests with this stack:
create_pds.sqlfile for the PDS to be created on Nessie and amy_first_query.sqlfile for the VDS to be created from the PDS on a Space in the Staging folder:Starting the project with dbt run correctly creates the
test_1branch and creates pds and vds with the correct points to the specified branch.If we rerun dbt run without changing anything, it checks whether a table with that name already exists in the branch; if it does, it is deleted and then recreated.
In create_pds.sql, you can also add the
nessie_refconfig, specifying a valid reference (for example, the tag created at the beginning):test_2branch is created starting from the init tag. This can be useful if we want to create PDSs starting from specific tags/branches/commits.test_2branch is correctly created starting from the tag.branchornessie_refconfig, the behavior is the usual one.Changelog
Contributor License Agreement
Related Issue