Skip to content

zookeeper: indent fix for pod annotations #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danieljimenez wants to merge 8 commits into
base: master
Choose a base branch
from
Open

zookeeper: indent fix for pod annotations #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a366d4f
Fix indent issue for zookeeper pod annotations
danieljimenez Jul 15, 2025
31b7ce7
duplicate requests into limits for now
danieljimenez Jul 15, 2025
e6ed3e3
duplicate requests into limits for now
danieljimenez Jul 15, 2025
39dc6fb
Update dremio-master.yaml
brandonaikey Mar 2, 2026
7f5c117
Update values.yaml
brandonaikey Mar 2, 2026
6a73f92
Merge pull request #1 from brandonaikey/patch-1
danieljimenez Mar 2, 2026
3f22f3a
Update _helpers_coordinator.tpl
brandonaikey Apr 7, 2026
0dc82b1
Merge pull request #2 from brandonaikey/add-volumeclaimannotations-he…
danieljimenez Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions charts/dremio_v2/templates/_helpers_coordinator.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,3 +247,13 @@ Coordinator - Active Processor Count
{{- $coordinatorCpu -}}
{{- end -}}
{{- end -}}

{{/*
Coordinator - Volume Claim Annotations
*/}}
{{- define "dremio.coordinator.volumeClaimAnnotations" -}}
{{- if $.Values.coordinator.volumeClaimAnnotations -}}
annotations:
{{- toYaml $.Values.coordinator.volumeClaimAnnotations | nindent 2 }}
{{- end -}}
{{- end -}}
3 changes: 3 additions & 0 deletions charts/dremio_v2/templates/dremio-coordinator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ spec:
requests:
cpu: {{ $.Values.coordinator.cpu }}
memory: {{ $.Values.coordinator.memory }}Mi
limits:
cpu: {{ $.Values.coordinator.cpu }}
memory: {{ $.Values.coordinator.memory }}Mi
volumeMounts:
- name: dremio-config
mountPath: /opt/dremio/conf
Expand Down
3 changes: 3 additions & 0 deletions charts/dremio_v2/templates/dremio-executor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ spec:
requests:
cpu: {{ template "dremio.executor.cpu" (list $ $engineName) }}
memory: "{{ template "dremio.executor.memory" (list $ $engineName) }}Mi"
limits:
cpu: {{ template "dremio.executor.cpu" (list $ $engineName) }}
memory: "{{ template "dremio.executor.memory" (list $ $engineName) }}Mi"
volumeMounts:
- name: {{ template "dremio.executor.volumeClaimName" (list $ $engineName) }}
mountPath: /opt/dremio/data
Expand Down
4 changes: 4 additions & 0 deletions charts/dremio_v2/templates/dremio-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ spec:
requests:
cpu: {{ $.Values.coordinator.cpu }}
memory: {{ $.Values.coordinator.memory }}Mi
limits:
cpu: {{ $.Values.coordinator.cpu }}
memory: {{ $.Values.coordinator.memory }}Mi
volumeMounts:
- name: dremio-master-volume
mountPath: /opt/dremio/data
Expand Down Expand Up @@ -232,6 +235,7 @@ spec:
{{- include "dremio.coordinator.log.volumeClaimTemplate" $ | nindent 2 }}
- metadata:
name: dremio-master-volume
{{- include "dremio.coordinator.volumeClaimAnnotations" $ | nindent 6}}
spec:
accessModes: ["ReadWriteOnce"]
{{- include "dremio.coordinator.storageClass" $ | nindent 6 }}
Expand Down
5 changes: 4 additions & 1 deletion charts/dremio_v2/templates/zookeeper.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ spec:
labels:
app: zk
{{- include "dremio.zookeeper.podLabels" $ | nindent 8 }}
{{- include "dremio.zookeeper.podAnnotations" $ | nindent 8 }}
{{- include "dremio.zookeeper.podAnnotations" $ | nindent 6 }}
spec:
{{- include "dremio.zookeeper.serviceAccount" $ | nindent 6 }}
affinity:
Expand Down Expand Up @@ -113,6 +113,9 @@ spec:
requests:
cpu: {{ $.Values.zookeeper.cpu }}
memory: {{ $.Values.zookeeper.memory }}Mi
limits:
cpu: {{ $.Values.zookeeper.cpu }}
memory: {{ $.Values.zookeeper.memory }}Mi
ports:
- containerPort: 2181
name: client
Expand Down
3 changes: 3 additions & 0 deletions charts/dremio_v2/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ coordinator:
# the provisioned and maximum performance of the disk.
volumeSize: 512Gi

# Annotations specifically for the dremio-master PVC.
#volumeClaimAnnotations: {}

# Kubernetes Service Account
# Uncomment below to use a custom Kubernetes service account for the coordinator.
#serviceAccount: ""
Expand Down