Skip to content

DX-120297: updating the MCP to verify ES256 signatures#108

Merged
ssaumitra merged 1 commit into
mainfrom
feature/update-jwt-verifier-signature
May 7, 2026
Merged

DX-120297: updating the MCP to verify ES256 signatures#108
ssaumitra merged 1 commit into
mainfrom
feature/update-jwt-verifier-signature

Conversation

@ajulka-drem
Copy link
Copy Markdown
Contributor

@ajulka-drem ajulka-drem commented May 7, 2026

Summary

  • Supporting ES256 signed tokens (ECDSA); the MCP JWKS verifier previously only accepted RS256
  • Updated algorithms list in JWKSVerifier.verify() to accept RS256, ES256, ES384, and ES512, covering both legacy RSA and all ECDSA variants.
  • Added tests/servers/test_jwks_integration.py — a skipped-by-default integration test harness that validates a real JWKS endpoint and JWT, including
    tampered-token and garbage-token cases.

Test plan

  • Fill in JWKS_URL and TOKEN in tests/servers/test_jwks_integration.py with a live ES256-signed token and run uv run pytest
    tests/servers/test_jwks_integration.py -v -s to confirm the verifier accepts the token and returns valid claims.
  • Confirm a tampered token returns None (test already covers this).
  • Confirm existing unit tests still pass: uv run pytest tests/.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ssaumitra ssaumitra changed the title DX-120297: Dremio tokens are singed using ES256 so updating the MCP DX-120297: Dremio tokens are signed using ES256 so updating the MCP May 7, 2026
@ssaumitra ssaumitra changed the title DX-120297: Dremio tokens are signed using ES256 so updating the MCP DX-120297: updating the MCP to verify ES256 signatures May 7, 2026
@ajulka-drem ajulka-drem force-pushed the feature/update-jwt-verifier-signature branch from 155b672 to 0951096 Compare May 7, 2026 23:38
Copy link
Copy Markdown
Contributor

@ssaumitra ssaumitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ssaumitra ssaumitra merged commit 0630449 into main May 7, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants