DX-120975: Fix endpoint#113
Merged
Merged
Conversation
aniket-s-kulkarni
requested changes
May 15, 2026
aniket-s-kulkarni
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update AI tool API calls to use the same project-aware endpoint logic as the rest of the Dremio client.
list_tools()andinvoke_tool()now call/v0/projects/{project_id}/ai/toolswhen a project ID is configured.When no project ID is present, both paths fall back to /api/v3/ai/tools.
Updated tests to cover both project-scoped and non-project-scoped requests, and removed the hardcoded
/api/v4/ai/toolsSoftware-only paths.Validation
python3 -m py_compile src/dremioai/api/dremio/ai_tools.py tests/api/dremio/test_ai_tools.pyAlso added a fix to the
test_stdlib_logs_are_rendered_as_jsontest, which had a pre-existing error. The e2e tests that start real uvicorn servers trigger uvicorn's configure_logging(), which applies its default LOGGING_CONFIG — this explicitly sets uvicorn.access.propagate = False. That setting persisted across tests, so when test_stdlib_logs_are_rendered_as_json ran later, the uvicorn.access logger silently swallowed the log message instead of propagating it to the root handler.Added a reset_uvicorn_logger_propagation autouse fixture to conftest.py that resets propagate=True and clears handlers on uvicorn loggers after each test.