Feature/username password auth#28
Conversation
- Add username and password fields to Dremio configuration model - Implement username/password authentication via Dremio's /apiv2/login endpoint - Add validation to prevent conflicting authentication methods - Update CLI commands to support both --username/--password and --pat options - Maintain full backward compatibility with existing PAT configurations - Add comprehensive validation and error handling - Update documentation with examples for both authentication methods Changes: - src/dremioai/config/settings.py: Add username/password fields and validation - src/dremioai/api/transport.py: Implement username/password authentication logic - src/dremioai/servers/mcp.py: Add CLI options and validation for new auth method - README.md: Update documentation with authentication options and examples All existing tests pass (74/74) ensuring backward compatibility.
- Add .idea/, .vscode/, and editor swap files to .gitignore - Prevent IDE-specific files from being tracked in version control
|
|
|
@StevenMPhillips I was thinking about implementing sth similar, but IMO another approach would be better - curious about your thoughts. From Dremio's perspective, I see two important downsides to this approach: To me, 1/ outweighs 2/ by a landslide, but I can imagine that in the current AI hype 2/ helps in persuading enterprise people who want leverage MCP to purchase an enterprise edition. That being said, the community should be able to use this MCP server too. My solution would be to keep the code to get a login token from the api outside this codebase. E.g. create a script that: It might be a bit hack-ish, but OK to me for community edition use. And then the code here can stay secure and evolve with enterprise as well as community editions. Thoughts? |
3 participants
No description provided.