feat(oauth): Support multiple values in the “aud” claim for JWT client assertions - #185
Merged
Merged
Conversation
sji-buttercup
force-pushed
the
aud-field-multiple-value
branch
from
September 24, 2025 20:47
26e6d66 to
2e54cc4
Compare
adutra
reviewed
Sep 25, 2025
sji-buttercup
marked this pull request as ready for review
September 25, 2025 16:29
adutra
reviewed
Sep 25, 2025
adutra
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the quick changes @sji-buttercup !
I left a few minor remarks but this is almost good to go. Thanks!
…nfig/ClientAssertionConfig.java Co-authored-by: Alexandre Dutra <adutra@apache.org>
Co-authored-by: Alexandre Dutra <adutra@apache.org>
adutra
approved these changes
Sep 25, 2025
adutra
left a comment
Contributor
There was a problem hiding this comment.
Thank you for your contribution @sji-buttercup !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual tests were successful for both:
Now the audience will always be a list, but given that the
oauth2-oidc-sdkwill always convert one-element to a string when generating the assertion, I believe it should be fine:When I extract the claims set from the assertion with
assertion.getJWTClaimsSet().toJSONObject(), I can see that for a single audience, it's still a single string instead of a list.Fixes #184