feat(build): extract authmgr-oauth2-agent module with no Iceberg dependency#241
Open
adutra wants to merge 1 commit into
Open
feat(build): extract authmgr-oauth2-agent module with no Iceberg dependency#241adutra wants to merge 1 commit into
adutra wants to merge 1 commit into
Conversation
adutra
commented
May 22, 2026
| .hasMessageContaining("Failed to read PEM file") | ||
| .rootCause() | ||
| .hasMessageContaining("not enough content"); | ||
| .hasMessageContaining("Illegal base64 character"); |
Contributor
Author
There was a problem hiding this comment.
We are now using the JDK decoder, not Apache Commons brought transitively by Iceberg.
adutra
commented
May 22, 2026
| @SuppressWarnings("resource") | ||
| public PolarisContainer() { | ||
| super("apache/polaris:1.3.0-incubating"); | ||
| super("apache/polaris:1.5.0"); |
Contributor
Author
There was a problem hiding this comment.
Unrelated, but quite consensual I hope :-)
dimas-b
reviewed
May 22, 2026
| * limitations under the License. | ||
| */ | ||
| package com.dremio.iceberg.authmgr.oauth2.config.validator; | ||
| package com.dremio.iceberg.authmgr.oauth2.agent.config.validator; |
There was a problem hiding this comment.
If this module is not supposed to have Iceberg deps, having iceberg in the package name looks odd 🤔
…ndency Fixes dremio#239. Introduces a new `:authmgr-oauth2-agent` Gradle module containing the entire OAuth2 token engine (`OAuth2Agent`, all `Flow` implementations, `OAuth2Config`, and every supporting subpackage) with zero Iceberg compile-time dependencies, making it usable by non-Iceberg callers (custom REST clients, Kafka connectors, ad-hoc tooling). `:authmgr-oauth2-core` is now a thin two-class Iceberg SPI adapter (`OAuth2Manager` + `OAuth2Session`). Bundle modules (`runtime`, `standalone`) continue to shadow `:authmgr-oauth2-core` and pick up the agent transitively; their sources/javadoc JARs now merge both modules. Test fixtures are split accordingly: agent `testFixtures` contain the Iceberg-free `TestEnvironment` and all expectation helpers; core `testFixtures` add `IcebergTestEnvironment extends TestEnvironment` and `IcebergRestExpectation` for the two Iceberg-specific catalog mocks. The new `:authmgr-oauth2-agent` module now has a new root package: `com.dremio.iceberg.authmgr.oauth2.agent`. The existing `:authmgr-oauth2-core` keeps its current package: `com.dremio.iceberg.authmgr.oauth2`, in order to avoid user-facing regressions since this module contains the Auth Manager implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #239.
Introduces a new
:authmgr-oauth2-agentGradle module containing the entire OAuth2 token engine (OAuth2Agent, allFlowimplementations,OAuth2Config, and every supporting subpackage) with zero Iceberg compile-time dependencies, making it usable by non-Iceberg callers (custom REST clients, Kafka connectors, ad-hoc tooling).:authmgr-oauth2-coreis now a thin two-class Iceberg SPI adapter (OAuth2Manager+OAuth2Session). Bundle modules (runtime,standalone) continue to shadow:authmgr-oauth2-coreand pick up the agent transitively; their sources/javadoc JARs now merge both modules.Test fixtures are split accordingly: agent
testFixturescontain the Iceberg-freeTestEnvironmentand all expectation helpers; coretestFixturesaddIcebergTestEnvironment extends TestEnvironmentandIcebergRestExpectationfor the two Iceberg-specific catalog mocks.The new
:authmgr-oauth2-agentmodule now has a new root package:com.dremio.iceberg.authmgr.oauth2.agent. The existing:authmgr-oauth2-corekeeps its current package:com.dremio.iceberg.authmgr.oauth2, in order to avoid user-facing regressions since this module contains the Auth Manager implementation.