Add 7 write tools (draft-safe) with opt-in gating#23
Open
daverad wants to merge 3 commits into
Open
Conversation
Merges 32 upstream commits from drewburchfield/help-scout-mcp-server including customer/org tools, navigator plugin, and bugfixes. Preserves all 7 write tools (createReply, createNote, updateConversationStatus, createConversation, assignConversation, listUsers, listMailboxes) with draft-by-default safety and HELPSCOUT_ENABLE_WRITES gating. https://claude.ai/code/session_01FykTztFCP7qYsq89d9Wth8
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
daverad
changed the title
POST operations (createReply, createNote, createConversation) are not idempotent. If the server processes the request but returns a 5xx or timeout, retrying would create duplicate emails/notes/conversations. Pass retries: 0 config to executeWithRetry for POST method. Addresses review feedback from drewburchfield#23. https://claude.ai/code/session_01FykTztFCP7qYsq89d9Wth8
The regex required a numeric ID in the path, so POST /conversations (no ID) never triggered cache invalidation. Broadened to match any conversations endpoint. Addresses review feedback from drewburchfield#23. https://claude.ai/code/session_01FykTztFCP7qYsq89d9Wth8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 7 write tools to the MCP server, building on patterns from #19 by @jcwatson11 — thank you for the excellent foundation! 🙏
This PR is rebased on top of the latest
main(v1.7.0+), incorporating all recent upstream changes that landed after #19 was opened — including customer/org tools, PII redaction, navigator plugin, and bugfixes.Key design choices:
createReplyandcreateConversationcreate drafts, not sent messagesHELPSCOUT_ENABLE_WRITES=true(off by default)Write Tools
createReplycreateNoteupdateConversationStatuscreateConversationassignConversationlistUserslistMailboxesSafety
HELPSCOUT_ENABLE_WRITES=truecreateReplyandcreateConversationdefault to draft mode