Skip to content

Fixes #12 with subdomain support in the config#27

Open
keithjgrant wants to merge 3 commits intodrewzboto:masterfrom
keithjgrant:master
Open

Fixes #12 with subdomain support in the config#27
keithjgrant wants to merge 3 commits intodrewzboto:masterfrom
keithjgrant:master

Conversation

@keithjgrant
Copy link

This provides subdomain support as outlined in this comment (#12 (comment)). Includes documentation updates and new tests.

@drewzboto
Copy link
Owner

Cool thanks for the PR. Will get in for the next release. Appreciate the help!

@stereokai
Copy link

What about this issue? We also need this. Badly. Our lives depend on it! @drewzboto to the rescue!

@drewzboto
Copy link
Owner

I'm debating how best to combine this with the PR from #31. It's essentially the same problem, but with a different match. I'll rewrite this PR to match #31 and provide a prebuilt function for domain/subdomain matching

@drewzboto
Copy link
Owner

i'll target it for the 2.0.0 release. soon! sorry for the wait, i've been a too many planes lately to find time to code

@stereokai
Copy link

At least you get to travel! It sounds great. Care to share your thoughts with us? Perhaps we can help.

@drewzboto
Copy link
Owner

I'm thinking of converting all the matching as functions. so in the config, you can specify a presupplied function, or write your own to identify when to proxy. I'll spec that out shortly. Happy to make people contributors if that makes things go faster. I know i'm a bottleneck

@shairez
Copy link
Contributor

shairez commented Feb 26, 2014

Hey guys, any news about this PR? :)

@stereokai
Copy link

Shai, I eventually used another tool - grunt-modrewrite as a middleware with connect, to give us Apache-like URL rewrites, as a substitute to subdomain-rule proxy. That's all we needed really.
מקווה שזה עזר :)

@shairez
Copy link
Contributor

shairez commented Feb 28, 2014

Thanks Tom! you're awesome :)

Guys, BTW, anything I can do to help?

@drewzboto drewzboto added this to the 0.2.0 milestone Mar 11, 2014
@icd2k3
Copy link

icd2k3 commented Oct 27, 2014

Hey everyone, I know this thread is from a while ago, but does anyone have any tips for setting this up with either grunt-contrib-proxy or grunt-modrewrite?

I have an environment setup like so:
[local.site.com] needs to access api at [api-subdomain.site.com]

can't seem to get it working correctly. Thanks for any advice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants