rewriteCookiePath option, to rewrite the "Path" from "Set-Cookie" response headers#32
rewriteCookiePath option, to rewrite the "Path" from "Set-Cookie" response headers#32gil wants to merge 2 commits intodrewzboto:masterfrom
Conversation
|
Thanks, appreciate the PR. Let me think a bit on how we can make the rewrite configuration a bit nicer (for both the rewrite and cookie). I'd prefer to make it obvious those to aspects are related |
|
Cool! I'll try to think about it here and how it can be better implemented. |
|
Maybe something like this? rewrite: [
new ContextRewrite('^/changingcontext', '/anothercontext'),
new ContextRewrite('^/api', '/api2')
new CookiePathRewrite('^/api', '/')
] |
|
If we could provide standard functions instead of using a new instance, that would work nicely. That would also allow people to tuck in their own functions that aren't OOTB. var proxyUtils = require("./lib/utils.js"); This would be a breaking change to the rewrite configuration. But probably worth it for the extra flexibility. |
|
Is there an update on the rewrite cookie functionality? |
|
should have something out over the holidays |
|
Any progress on this? :) |
|
also interested in this. |
|
Sorry, still on my plate. 2014 started off a bit crazy, haven't had much time to dedicate to this project. Should expect things to slow down shortly to give this another kick. |
|
Come on guys, I can't live without this feature. Please Implement cookieRewrite |
|
Hi guys, can anyone check my new pull request? I've updated it to the newer version and with the syntax discussed here. I just didn't have the time to do better testing, so please help me test it before accepting the pull request. You can add to your "package.json": |
|
Also, I've changed in a way that it will still support the old syntax, so it won't break current users. |
|
Thanks for the update! I'm not too concerned about the old syntax, i think we'll have to go this route for the next major version. let me give this a spin over the next week or so. |
|
If you don't want to support the old syntax, just remove these lines: https://github.com/gil/grunt-connect-proxy/blob/10a6ca6e886fdaf4444e7eaff410640e22bf8760/lib/utils.js#L81-L90 I'll try to do better testing during the week. If you need anything, just let me know. |
No description provided.