-
-
Notifications
You must be signed in to change notification settings - Fork 0
chore: add Husky pre-commit hooks and auto-merge workflow #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
09ac09a
chore: add Husky pre-commit hooks and auto-merge workflow
tomymaritano 5cd5520
fix: use gh pr merge --auto for automerge workflow
tomymaritano 2ef5a9a
ci: level up CI pipeline and Husky hooks
tomymaritano a8bf258
fix: remove process.env.NODE_ENV check from browser-only plugin-api
tomymaritano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| name: Auto-merge | ||
|
|
||
| on: | ||
| pull_request_review: | ||
| types: [submitted] | ||
| check_suite: | ||
| types: [completed] | ||
| workflow_run: | ||
| workflows: [CI] | ||
| types: [completed] | ||
|
|
||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| automerge: | ||
| runs-on: ubuntu-latest | ||
| if: >- | ||
| github.event.pull_request.user.login == 'tomymaritano' || | ||
| github.event.workflow_run.head_repository.owner.login == 'tomymaritano' | ||
| steps: | ||
| - name: Enable auto-merge for owner PRs | ||
| uses: peter-evans/enable-pull-request-automerge@v3 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| merge-method: merge | ||
|
|
||
| dependabot: | ||
| runs-on: ubuntu-latest | ||
| if: github.actor == 'dependabot[bot]' | ||
| steps: | ||
| - name: Auto-merge dependabot PRs | ||
| uses: peter-evans/enable-pull-request-automerge@v3 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| merge-method: merge | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| pnpm lint-staged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition matches owner
workflow_runevents from normal branch pushes as well as PRs, andCIis configured to run onpushtomain/developin.github/workflows/ci.yml. For those push-triggered completions there is no pull request in the event payload, but the job still callspeter-evans/enable-pull-request-automerge@v3without apull-request-number, so the auto-merge job will fail/no-op on regular owner pushes instead of only handling PRs. Add a guard for PR-originated workflow runs (for example checkinggithub.event.workflow_run.event == 'pull_request'orworkflow_run.pull_requestspresence) before invoking the action.Useful? React with 👍 / 👎.