release: merge develop into main

CHANGELOG.md

@@ -2,12 +2,12 @@
 
 ### Features
 
-* v0.14.0 — local HTTP API, quick capture, plugins, Vercel fix ([#232](https://github.com/tomymaritano/readide/issues/232)) ([19301a8](https://github.com/tomymaritano/readide/commit/19301a895f15fa9464d67b7e879502e751b08ab8))
+- v0.14.0 — local HTTP API, quick capture, plugins, Vercel fix ([#232](https://github.com/tomymaritano/readide/issues/232)) ([19301a8](https://github.com/tomymaritano/readide/commit/19301a895f15fa9464d67b7e879502e751b08ab8))
 
 ### Bug Fixes
 
-* v0.14.1 — ASAR startup crash fix ([#234](https://github.com/tomymaritano/readide/issues/234)) ([b051785](https://github.com/tomymaritano/readide/commit/b0517852c52241a633344907974e962a376f8dc1))
-* v0.14.2 — ASAR startup crash fix (devDependencies) ([#236](https://github.com/tomymaritano/readide/issues/236)) ([17b951a](https://github.com/tomymaritano/readide/commit/17b951a634ea55992ce29afad1d969dd821f1f29))
+- v0.14.1 — ASAR startup crash fix ([#234](https://github.com/tomymaritano/readide/issues/234)) ([b051785](https://github.com/tomymaritano/readide/commit/b0517852c52241a633344907974e962a376f8dc1))
+- v0.14.2 — ASAR startup crash fix (devDependencies) ([#236](https://github.com/tomymaritano/readide/issues/236)) ([17b951a](https://github.com/tomymaritano/readide/commit/17b951a634ea55992ce29afad1d969dd821f1f29))
 
 ## [0.14.1](https://github.com/tomymaritano/readide/compare/v0.14.0...v0.14.1) (2026-04-24)
 

apps/desktop/src/preload/api/localServer.ts

@@ -18,6 +18,10 @@ export function createLocalServerApi(): LocalServerAPI {
     start: (port?: number) => ipcRenderer.invoke('localServer:start', port),
     stop: () => ipcRenderer.invoke('localServer:stop'),
     status: () => ipcRenderer.invoke('localServer:status'),
-    getToken: () => ipcRenderer.invoke('localServer:getToken'),
+    getToken: async () => {
+      const result = await ipcRenderer.invoke('localServer:getToken');
+      if (!result.ok) throw new Error(result.error ?? 'Failed to get token');
+      return result.value as string;
+    },
   };
 }

apps/desktop/src/preload/api/settings.ts

@@ -36,9 +36,10 @@ export function createSettingsApi(): SettingsAPI {
 export function createIpcApi(): IpcAPI {
   return {
     on: (channel: string, listener: (...args: unknown[]) => void) => {
-      ipcRenderer.on(channel, (_event, ...args) => listener(...args));
+      const handler = (_event: Electron.IpcRendererEvent, ...args: unknown[]) => listener(...args);
+      ipcRenderer.on(channel, handler);
       return () => {
-        ipcRenderer.removeAllListeners(channel);
+        ipcRenderer.removeListener(channel, handler);
       };
     },
   };

apps/desktop/src/renderer/App.tsx

@@ -438,12 +438,44 @@ function NotesApp() {
   // Plugin runtime: init once, React observes
   const discoveredPlugins = useStore(pluginRuntimeStore, s => s.plugins);
   const pluginErrors = useStore(pluginRuntimeStore, s => s.errors);
+  const [builtInEnabledMap, setBuiltInEnabledMap] = useState<Record<string, boolean> | null>(null);
 
   useEffect(() => {
     void pluginRuntimeStore.getState().init();
+    // Load built-in plugin enabled states
+    void (async () => {
+      const stateList = await window.readied.plugins.listState();
+      const map: Record<string, boolean> = {};
+      for (const s of stateList) {
+        map[s.pluginId] = s.enabled;
+      }
+      setBuiltInEnabledMap(map);
+    })();
+  }, []);
+
+  // Re-check built-in enabled state when plugins reload
+  useEffect(() => {
+    const handler = () => {
+      void (async () => {
+        const stateList = await window.readied.plugins.listState();
+        const map: Record<string, boolean> = {};
+        for (const s of stateList) {
+          map[s.pluginId] = s.enabled;
+        }
+        setBuiltInEnabledMap(map);
+      })();
+    };
+    return window.readied.ipc.on('plugins:reload', handler);
   }, []);
 
-  const allPlugins = useMemo(() => [...builtInPlugins, ...discoveredPlugins], [discoveredPlugins]);
+  const allPlugins = useMemo(() => {
+    // Don't mount built-in plugins until the enabled state is loaded
+    // to avoid activating disabled plugins on the initial render
+    const enabledBuiltIn = builtInEnabledMap
+      ? builtInPlugins.filter(p => builtInEnabledMap[p.id] !== false)
+      : [];
+    return [...enabledBuiltIn, ...discoveredPlugins];
+  }, [discoveredPlugins, builtInEnabledMap]);
 
   const configBridge = useMemo(
     () => ({

apps/desktop/src/renderer/components/MarkdownEditor.tsx

@@ -575,22 +575,26 @@ export const MarkdownEditor = forwardRef<MarkdownEditorHandle, MarkdownEditorPro
             userEvent: 'input.paste',
           });
 
-          // Fetch title in background and replace with markdown link
+          // Fetch title in background and replace with markdown link.
+          // Track the exact range where we inserted the URL so later
+          // edits don't cause us to rewrite the wrong occurrence.
+          const insertedFrom = from;
+          const insertedTo = from + plainText.length;
           window.readied.editor
             .fetchUrlTitle(plainText)
             .then(({ title }) => {
               if (!title) return;
-              // Find the URL in the document — it may have moved due to edits
+              // Verify the URL still sits at the expected position
               const currentDoc = view.state.doc.toString();
-              const urlIndex = currentDoc.indexOf(plainText, from > 20 ? from - 20 : 0);
-              if (urlIndex === -1) return;
+              const textAtRange = currentDoc.slice(insertedFrom, insertedTo);
+              if (textAtRange !== plainText) return;
               // Verify it's still a bare URL (not already wrapped in markdown link)
-              const charBefore = urlIndex > 0 ? currentDoc[urlIndex - 1] : '';
+              const charBefore = insertedFrom > 0 ? currentDoc[insertedFrom - 1] : '';
               if (charBefore === '(' || charBefore === '<') return;
               const mdLink = `[${title}](${plainText})`;
               view.dispatch({
-                changes: { from: urlIndex, to: urlIndex + plainText.length, insert: mdLink },
-                selection: EditorSelection.cursor(urlIndex + mdLink.length),
+                changes: { from: insertedFrom, to: insertedTo, insert: mdLink },
+                selection: EditorSelection.cursor(insertedFrom + mdLink.length),
                 userEvent: 'input.paste',
               });
             })

apps/desktop/src/renderer/pages/settings/sections/plugins/PluginCard.tsx

@@ -59,7 +59,6 @@ export function PluginCard({
             id={`plugin-${name.toLowerCase().replace(/\s+/g, '-')}`}
             checked={enabled}
             onChange={checked => onToggle?.(checked)}
-            disabled={isBuiltIn}
           />
           {!isBuiltIn && onUninstall && (
             <button

apps/desktop/src/renderer/pages/settings/sections/plugins/index.tsx

@@ -47,6 +47,7 @@ export function PluginsSection() {
   const [pluginsPath, setPluginsPath] = useState('');
   const [isReloading, setIsReloading] = useState(false);
   const [configValues, setConfigValues] = useState<Record<string, Record<string, unknown>>>({});
+  const [builtInEnabled, setBuiltInEnabled] = useState<Record<string, boolean>>({});
   const [refreshKey, setRefreshKey] = useState(0);
 
   // Listen for plugin install events from BrowseTab
@@ -77,6 +78,13 @@ export function PluginsSection() {
         }));
         setPlugins(pluginList);
 
+        // Load built-in plugin enabled states from DB
+        const builtInStates: Record<string, boolean> = {};
+        for (const bp of builtInPlugins) {
+          builtInStates[bp.id] = stateMap.get(bp.id) ?? true;
+        }
+        setBuiltInEnabled(builtInStates);
+
         // Load config values for all plugins with schemas (built-in + community)
         const configs: Record<string, Record<string, unknown>> = {};
 
@@ -111,11 +119,14 @@ export function PluginsSection() {
     void loadPlugins();
   }, [refreshKey]);
 
-  // Toggle plugin enabled/disabled
+  // Toggle plugin enabled/disabled (works for both built-in and community)
   const handleToggle = useCallback(async (pluginId: string, enabled: boolean) => {
     try {
       await window.readied.plugins.setEnabled(pluginId, enabled);
+      // Update community plugins state
       setPlugins(prev => prev.map(p => (p.id === pluginId ? { ...p, enabled } : p)));
+      // Update built-in plugins state
+      setBuiltInEnabled(prev => ({ ...prev, [pluginId]: enabled }));
       // Trigger reload in main window so preview updates immediately
       window.readied.plugins.requestReload();
       toast.success(`Plugin ${enabled ? 'enabled' : 'disabled'}`);
@@ -293,7 +304,8 @@ export function PluginsSection() {
                   version={plugin.version}
                   description={plugin.description}
                   isBuiltIn={true}
-                  enabled={true}
+                  enabled={builtInEnabled[plugin.id] ?? true}
+                  onToggle={enabled => handleToggle(plugin.id, enabled)}
                   configSchema={BUILT_IN_CONFIG_SCHEMAS[plugin.id]}
                   configValues={configValues[plugin.id]}
                   onConfigChange={(key, value) => handleConfigChange(plugin.id, key, value)}

packages/mcp-server/package.json

@@ -14,16 +14,19 @@
   },
   "scripts": {
     "build": "tsc",
-    "dev": "tsx src/index.ts"
+    "dev": "tsx src/index.ts",
+    "test": "vitest run"
   },
   "dependencies": {
     "@modelcontextprotocol/sdk": "^1.29.0",
-    "sql.js": "^1.14.1",
+    "better-sqlite3": "^11.7.0",
     "zod": "^4.3.6"
   },
   "devDependencies": {
+    "@types/better-sqlite3": "^7.6.0",
     "@types/node": "^22.0.0",
     "tsx": "^4.19.0",
-    "typescript": "^5.7.0"
+    "typescript": "^5.7.0",
+    "vitest": "^3.2.1"
   }
 }

packages/mcp-server/src/__tests__/fts5-triggers.test.ts

@@ -0,0 +1,160 @@
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import Database from 'better-sqlite3';
+import { openDb } from '../db.js';
+
+/**
+ * Minimal schema that mirrors the real Readied database enough to
+ * exercise the FTS5 triggers that caused "no such module: fts5"
+ * when the MCP server used sql.js (which lacks FTS5).
+ */
+const SCHEMA = `
+  CREATE TABLE notes (
+    id TEXT PRIMARY KEY,
+    content TEXT NOT NULL,
+    title TEXT NOT NULL,
+    created_at TEXT NOT NULL,
+    updated_at TEXT NOT NULL,
+    word_count INTEGER NOT NULL DEFAULT 0,
+    notebook_id TEXT DEFAULT 'inbox',
+    is_pinned INTEGER DEFAULT 0,
+    is_deleted INTEGER DEFAULT 0,
+    status TEXT DEFAULT 'active',
+    needs_sync INTEGER DEFAULT 0,
+    local_version INTEGER DEFAULT 1,
+    sync_version INTEGER DEFAULT 0
+  );
+
+  CREATE TABLE notebooks (
+    id TEXT PRIMARY KEY,
+    name TEXT NOT NULL,
+    parent_id TEXT,
+    depth INTEGER NOT NULL DEFAULT 0,
+    "order" INTEGER NOT NULL DEFAULT 0,
+    created_at TEXT NOT NULL,
+    updated_at TEXT NOT NULL
+  );
+
+  INSERT INTO notebooks (id, name, created_at, updated_at)
+  VALUES ('inbox', 'Inbox', datetime('now'), datetime('now'));
+
+  -- FTS5 virtual table (migration 008)
+  CREATE VIRTUAL TABLE notes_fts USING fts5(
+    id UNINDEXED,
+    title,
+    content,
+    tokenize='porter unicode61'
+  );
+
+  -- Trigger: sync FTS on INSERT
+  CREATE TRIGGER notes_fts_insert AFTER INSERT ON notes
+  WHEN NEW.is_deleted = 0 OR NEW.is_deleted IS NULL
+  BEGIN
+    INSERT INTO notes_fts(id, title, content)
+    VALUES (NEW.id, NEW.title, NEW.content);
+  END;
+
+  -- Trigger: sync FTS on UPDATE (delete + re-insert)
+  CREATE TRIGGER notes_fts_update AFTER UPDATE ON notes
+  BEGIN
+    DELETE FROM notes_fts WHERE id = OLD.id;
+    INSERT INTO notes_fts(id, title, content)
+    SELECT NEW.id, NEW.title, NEW.content
+    WHERE NEW.is_deleted = 0 OR NEW.is_deleted IS NULL;
+  END;
+
+  -- Trigger: sync FTS on DELETE
+  CREATE TRIGGER notes_fts_delete AFTER DELETE ON notes
+  BEGIN
+    DELETE FROM notes_fts WHERE id = OLD.id;
+  END;
+`;
+
+describe('FTS5 trigger execution', () => {
+  let db: Database.Database;
+
+  beforeEach(() => {
+    db = new Database(':memory:');
+    db.exec(SCHEMA);
+  });
+
+  afterEach(() => {
+    db.close();
+  });
+
+  it('INSERT fires notes_fts_insert trigger without error', () => {
+    const now = new Date().toISOString();
+
+    expect(() => {
+      db.prepare(
+        `INSERT INTO notes (id, content, title, created_at, updated_at, word_count, notebook_id, status, needs_sync, local_version, sync_version)
+         VALUES (?, ?, ?, ?, ?, ?, ?, 'active', 1, 1, 0)`
+      ).run('note-1', '# Test Note\n\nHello world', 'Test Note', now, now, 2, 'inbox');
+    }).not.toThrow();
+
+    const ftsRow = db.prepare('SELECT * FROM notes_fts WHERE notes_fts MATCH ?').get('hello');
+    expect(ftsRow).toBeTruthy();
+  });
+
+  it('UPDATE fires notes_fts_update trigger without error', () => {
+    const now = new Date().toISOString();
+    db.prepare(
+      `INSERT INTO notes (id, content, title, created_at, updated_at, word_count)
+       VALUES (?, ?, ?, ?, ?, ?)`
+    ).run('note-1', '# Original\n\nOriginal content', 'Original', now, now, 2);
+
+    expect(() => {
+      db.prepare(
+        'UPDATE notes SET content = ?, title = ?, updated_at = ?, word_count = ?, needs_sync = 1, local_version = local_version + 1 WHERE id = ?'
+      ).run('# Updated\n\nBrand new content', 'Updated', now, 3, 'note-1');
+    }).not.toThrow();
+
+    const oldMatch = db.prepare('SELECT * FROM notes_fts WHERE notes_fts MATCH ?').get('original');
+    expect(oldMatch).toBeUndefined();
+
+    const newMatch = db.prepare('SELECT * FROM notes_fts WHERE notes_fts MATCH ?').get('brand');
+    expect(newMatch).toBeTruthy();
+  });
+
+  it('soft-delete UPDATE removes entry from FTS index', () => {
+    const now = new Date().toISOString();
+    db.prepare(
+      `INSERT INTO notes (id, content, title, created_at, updated_at, word_count)
+       VALUES (?, ?, ?, ?, ?, ?)`
+    ).run('note-1', '# Trashable\n\nGoing away', 'Trashable', now, now, 2);
+
+    expect(() => {
+      db.prepare(
+        'UPDATE notes SET is_deleted = 1, updated_at = ?, needs_sync = 1 WHERE id = ?'
+      ).run(now, 'note-1');
+    }).not.toThrow();
+
+    const match = db.prepare('SELECT * FROM notes_fts WHERE notes_fts MATCH ?').get('trashable');
+    expect(match).toBeUndefined();
+  });
+
+  it('DELETE fires notes_fts_delete trigger without error', () => {
+    const now = new Date().toISOString();
+    db.prepare(
+      `INSERT INTO notes (id, content, title, created_at, updated_at, word_count)
+       VALUES (?, ?, ?, ?, ?, ?)`
+    ).run('note-1', '# Deletable\n\nWill be removed', 'Deletable', now, now, 3);
+
+    expect(() => {
+      db.prepare('DELETE FROM notes WHERE id = ?').run('note-1');
+    }).not.toThrow();
+
+    const match = db.prepare('SELECT * FROM notes_fts WHERE notes_fts MATCH ?').get('deletable');
+    expect(match).toBeUndefined();
+  });
+});
+
+describe('FTS5 runtime check', () => {
+  it('openDb succeeds with an in-memory database (FTS5 available)', () => {
+    const db = openDb(':memory:');
+    expect(db).toBeTruthy();
+    // Verify FTS5 actually works on the returned connection
+    db.prepare('CREATE VIRTUAL TABLE _test_fts USING fts5(x)').run();
+    db.prepare('DROP TABLE _test_fts').run();
+    db.close();
+  });
+});