feat(editor): indent lists by the marker above - #523
Conversation
|
Warning Review limit reached
Next review available in: 45 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
## Why Inkdrop v6.1 shipped 30 `editor:*` line commands and Enter that continues a list. We had copy/move line only because CodeMirror's default keymap binds them — they were invisible in the palette, and Enter was a plain newline. ## What - Palette + dispatch for the v6.1 set: copy/move line, select line, matching bracket, subword, comments, sort, join, case, find-under, split selection, scroll. - Enter continues bullets, numbered lists (and renumbers), tasks (`- [ ]`), and blockquotes. An empty item outdents / leaves the block. Fences fall through. - `<!-- -->` via `toggleComment` in Markdown (line comments still come from the fenced language). - Multiple selections enabled so "select all occurrences" actually adds cursors. - Keybindings that match Inkdrop where they don't collide: - Alt+↑/↓ move line, Shift+Alt+↑/↓ copy (already in CM) - Mod+L select line, Mod+/ toggle comment, Mod+F3 find under, Alt+F3 select all - F5/F9 sort, Ctrl+J join, Ctrl+Alt+←/→ subword (CM keymap — registry treats Ctrl as Mod) - **Not rebound:** Mod+Enter stays Edit with AI (`insert-blank-line` is palette-only). Mod+Shift+Enter stays follow-link (`insert-line-before` is palette-only). Mod+D stays duplicate note. Independent of #522 and #523. ## Test plan - [ ] `- item` then Enter → new `- ` sibling. Enter on an empty `- ` → leaves the list. - [ ] `1. a` / `2. b`, Enter at the end of a → `2. ` inserted, `b` becomes `3.` - [ ] `> quote` Enter continues `> `. Empty `> ` exits. - [ ] Enter inside a fence is a normal newline. - [ ] Select three lines, Command Palette → Sort Lines. - [ ] Alt+↑ moves the line. Shift+Alt+↓ copies it down. - [ ] Mod+L selects the line. Mod+/ wraps the line in `<!-- -->`. - [ ] Palette → Join Lines on two lines. Ctrl+J does the same. - [ ] Command Palette lists the new editor commands. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added enhanced Markdown editing, including automatic continuation for lists, task lists, blockquotes, and ordered-list numbering. * Added editor commands for selecting, moving, sorting, joining, splitting, and transforming lines and text. * Added search-under, occurrence selection, scrolling, cursor centering, and multiple-selection support. * Added the new editing actions to the command palette with keyboard shortcuts. * **Bug Fixes** * Markdown comments are now recognized correctly. * List continuation is disabled within fenced code blocks and handles empty list items appropriately. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
3003b15 to
4863346
Compare
Tab always added two spaces, so a bullet under `1.` never nested. Match Inkdrop: indent by the marker width, renumber, color marks.
4863346 to
068ec3f
Compare
Why
Tab always indented by two spaces. That nests a bullet under
-, but not under1.(needs 3) or10.(needs 4). Inkdrop v6.1 fixed this last week; we still hadindentWithTab.What
-→ 2,1.→ 3,10.→ 4). Descendants move with the parent.--md-list-mark-color,--md-list-mark-2-color,--md-list-mark-3-color). Deeper levels cycle. Preview markers stay text-colored unless a theme opts into--mde-preview-list-marker-*.indentWithTab.Independent of #522.
Test plan
1. parentthen- child. Tab on the bullet — it should sit three spaces in and render nested.1. a/2. b/3. c— Tab on2.→ nested1. b, outer2. c.