Skip to content

feat(desktop): split Themes and nested plugin pages - #525

Merged
tomymaritano merged 1 commit into
developfrom
feat/settings-themes-plugins
Aug 20, 2026
Merged

feat(desktop): split Themes and nested plugin pages#525
tomymaritano merged 1 commit into
developfrom
feat/settings-themes-plugins

Conversation

@tomymaritano

Copy link
Copy Markdown
Collaborator

Why

Inkdrop Preferences has a Themes page of its own and nests Install / Updates under Plugins. Ours mixed palettes into Appearance, used in-page tabs for Browse, and “Updates” only meant the app updater.

What

  • Themes is a sidebar page (live palette cards). Appearance keeps base / accent / zoom / performance.
  • Plugins nested like Inkdrop: Installed (click Plugins), Install (today’s Browse + installFromSpec), Updates (community plugins whose registry version is newer). Badge on Updates. Not a store.
  • Keybindings page: live command table + Open keybindings.json.

Independent of #522#524.

Test plan

  • Settings → Themes: pick Parchment / Wave / Default. Appearance still has zoom and accent.
  • Settings → Plugins shows installed built-ins. Nested Install lists the catalog. Nested Updates is empty if everything matches, or offers Update if a community plugin is behind.
  • Settings → Keybindings lists chords. Open keybindings.json still works.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@tomymaritano, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: deda409a-c5a7-4d9d-a3e1-e9f80096389b

📥 Commits

Reviewing files that changed from the base of the PR and between 0efe42d and 6ca925f.

📒 Files selected for processing (12)
  • apps/desktop/src/renderer/pages/settings/SettingsApp.tsx
  • apps/desktop/src/renderer/pages/settings/components/SettingsSidebar.module.css
  • apps/desktop/src/renderer/pages/settings/components/SettingsSidebar.tsx
  • apps/desktop/src/renderer/pages/settings/sections/AppearanceSection.tsx
  • apps/desktop/src/renderer/pages/settings/sections/Keybindings.module.css
  • apps/desktop/src/renderer/pages/settings/sections/KeybindingsSection.tsx
  • apps/desktop/src/renderer/pages/settings/sections/ThemesSection.tsx
  • apps/desktop/src/renderer/pages/settings/sections/plugins/UpdatesTab.tsx
  • apps/desktop/src/renderer/pages/settings/sections/plugins/__tests__/version.test.ts
  • apps/desktop/src/renderer/pages/settings/sections/plugins/index.tsx
  • apps/desktop/src/renderer/pages/settings/sections/plugins/version.ts
  • apps/desktop/src/renderer/pages/settings/sections/themes/PaletteCard.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tomymaritano
tomymaritano force-pushed the feat/settings-themes-plugins branch from 197e882 to efe0694 Compare August 20, 2026 05:46
tomymaritano added a commit that referenced this pull request Aug 20, 2026
## Why

The Inkdrop shot with the desk showing through the sidebar is macOS
vibrancy plus translucent chrome. Wave is a solid hex. Default stays
opaque.

## What

- Official **Glass** palette: alpha `--bg-base` / `--bg-surface` so the
desktop reads through.
- Note windows on macOS use `vibrancy: under-window`; Windows gets
acrylic. Linux stays opaque. Settings window is unchanged.
- Sidebar and note-list columns get `backdrop-filter`. The editor pane
uses `--bg-elevated` so markdown stays readable.
- Performance Low already sets `--glass-blur: 0`.

Independent of #522#527. Pick Glass from Settings → Themes (after #525)
or Appearance palettes on develop.

## Test plan

- [ ] macOS: default theme still looks solid. Switch to Glass — sidebar
is frosted, wallpaper shows through.
- [ ] Editor text stays readable on Glass.
- [ ] Performance → Low: blur goes away.
- [ ] Windows/Linux: no crash; Glass is just a translucent dark palette.
Inkdrop keeps Themes on its own Preferences row and nests
Install/Updates under Plugins. Appearance stays zoom and accent.
@tomymaritano
tomymaritano force-pushed the feat/settings-themes-plugins branch from efe0694 to 6ca925f Compare August 20, 2026 05:48
@tomymaritano
tomymaritano merged commit 2865017 into develop Aug 20, 2026
16 checks passed
@tomymaritano
tomymaritano deleted the feat/settings-themes-plugins branch August 20, 2026 05:52
tomymaritano added a commit that referenced this pull request Aug 20, 2026
## Why

Cmd+K was a command list. Jump notebook / tag / heading were separate
modes. Inkdrop Telescope is one bar: type a prefix, fuzzy-rank the
source.

## What

- Prefixes in the same palette: `>` commands, `b ` notebooks, `t ` tags,
`#` headings. Existing mode commands (Quick Open, Jump to Notebook, …)
stay as aliases.
- `b work` scopes to notebooks; typing `blog` does not.
- Rank by subsequence (prefix hits first), not `includes`.
- Esc clears a prefix before closing.

Independent of #522#525.

## Test plan

- [ ] Cmd+K, type `b ` — notebooks. Type `t ` — tags. Type `#` —
headings. Type `>` — commands.
- [ ] `inb` ranks Inbox. `wo` still does not match Weekly.
- [ ] Esc with `b foo` in the box clears the query; Esc again closes.
- [ ] Jump to Notebook (the old command) still opens scoped to
notebooks.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
* Added scoped command palette searches for commands, notebooks, tags,
and headings.
* Added fuzzy matching that ranks relevant results, including
non-contiguous matches.
  * Updated the search hint to show supported prefixes.

* **Bug Fixes**
* Improved Escape-key behavior to clear active searches before closing
the palette.
* Improved filtering, accessibility text, rendering, and keyboard
behavior for scoped searches.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant