feat(desktop): split Themes and nested plugin pages - #525
Conversation
|
Warning Review limit reached
Next review available in: 54 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (12)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
197e882 to
efe0694
Compare
## Why The Inkdrop shot with the desk showing through the sidebar is macOS vibrancy plus translucent chrome. Wave is a solid hex. Default stays opaque. ## What - Official **Glass** palette: alpha `--bg-base` / `--bg-surface` so the desktop reads through. - Note windows on macOS use `vibrancy: under-window`; Windows gets acrylic. Linux stays opaque. Settings window is unchanged. - Sidebar and note-list columns get `backdrop-filter`. The editor pane uses `--bg-elevated` so markdown stays readable. - Performance Low already sets `--glass-blur: 0`. Independent of #522–#527. Pick Glass from Settings → Themes (after #525) or Appearance palettes on develop. ## Test plan - [ ] macOS: default theme still looks solid. Switch to Glass — sidebar is frosted, wallpaper shows through. - [ ] Editor text stays readable on Glass. - [ ] Performance → Low: blur goes away. - [ ] Windows/Linux: no crash; Glass is just a translucent dark palette.
Inkdrop keeps Themes on its own Preferences row and nests Install/Updates under Plugins. Appearance stays zoom and accent.
efe0694 to
6ca925f
Compare
## Why Cmd+K was a command list. Jump notebook / tag / heading were separate modes. Inkdrop Telescope is one bar: type a prefix, fuzzy-rank the source. ## What - Prefixes in the same palette: `>` commands, `b ` notebooks, `t ` tags, `#` headings. Existing mode commands (Quick Open, Jump to Notebook, …) stay as aliases. - `b work` scopes to notebooks; typing `blog` does not. - Rank by subsequence (prefix hits first), not `includes`. - Esc clears a prefix before closing. Independent of #522–#525. ## Test plan - [ ] Cmd+K, type `b ` — notebooks. Type `t ` — tags. Type `#` — headings. Type `>` — commands. - [ ] `inb` ranks Inbox. `wo` still does not match Weekly. - [ ] Esc with `b foo` in the box clears the query; Esc again closes. - [ ] Jump to Notebook (the old command) still opens scoped to notebooks. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added scoped command palette searches for commands, notebooks, tags, and headings. * Added fuzzy matching that ranks relevant results, including non-contiguous matches. * Updated the search hint to show supported prefixes. * **Bug Fixes** * Improved Escape-key behavior to clear active searches before closing the palette. * Improved filtering, accessibility text, rendering, and keyboard behavior for scoped searches. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Why
Inkdrop Preferences has a Themes page of its own and nests Install / Updates under Plugins. Ours mixed palettes into Appearance, used in-page tabs for Browse, and “Updates” only meant the app updater.
What
installFromSpec), Updates (community plugins whose registry version is newer). Badge on Updates. Not a store.Independent of #522–#524.
Test plan