fix(desktop): paint AuthGate above LoginBackdrop - #629
Merged
Conversation
Keep the magic-link form above the tunnel canvas on Linux AppImage, and portal Settings Account Sign In so the email flow is not clipped. Co-authored-by: Tomás Maritano <tomymaritano@gmail.com>
|
Warning Review limit reachedNext included review available in 6 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Portal already escaped Settings overflow; drop overlay backdrop-filter and paint the dialog on glass-bg-fallback so Linux Electron cannot composite the email field away. Co-authored-by: Tomás Maritano <tomymaritano@gmail.com>
Open Settings via globalThis so the evaluate callback typechecks without a DOM Window lib in the e2e tsconfig. Co-authored-by: Tomás Maritano <tomymaritano@gmail.com>
tomymaritano
marked this pull request as ready for review
August 26, 2026 20:00
tomymaritano
added a commit
that referenced
this pull request
Aug 26, 2026
AuthGate paint fix so the magic-link form sits above LoginBackdrop (#629).
Contributor
|
🎉 This PR is included in version 0.21.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
8 tasks
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 26, 2026
<!-- CURSOR_AGENT_PR_BODY_BEGIN --> ## Summary Replace AuthGate’s paper-and-ink tunnel with a vendored [React Bits Letter Glitch](https://www.reactbits.dev/backgrounds/letter-glitch) canvas. Dripnex is the hackable AI note taker; the first window now glitches a matrix-style letter grid behind a readable magic-link form. No `react-bits` / jsrepo / shadcn dependency. The effect lives in `letterGlitch.ts`, adapted from [DavidHDev/react-bits](https://github.com/DavidHDev/react-bits). Keeps the #629 stacking fix so Linux AppImage cannot cover the form: - `AUTH_GATE_FORM_Z_INDEX` (1) > `LOGIN_BACKDROP_Z_INDEX` (0) - canvas `clearRect` only — no opaque `#000` / `--bg-base` `fillRect` - `.screen` already paints `--bg-base`; outer vignette uses a transparent mix, not an opaque fill - `prefers-reduced-motion`: one painted frame, no rAF loop - `requestAnimationFrame` is invoked as a window method (unbound extract threw `Illegal invocation`) No guest path. No continue-locally skip. `OFFICIAL_THEMES` stays `[]`. No package.json bump, tag, Capture, or GitHub OAuth changes. ## Type of Change - [ ] Bug fix - [x] New feature - [ ] Breaking change - [ ] Documentation update ## Related Issues Follows #629 (AuthGate paint / stacking). Tomás asked for Letter Glitch as the AuthGate background. ## Checklist - [x] I've read [CONTRIBUTING.md](../CONTRIBUTING.md) - [x] Tests pass locally (`pnpm test`) - [x] Build succeeds (`pnpm --filter @dripnex/desktop build`) - [x] PR targets `develop` branch (not `main`) ## Screenshots Unauthenticated main window: Letter Glitch behind a readable AuthGate (email + Email me a link). [AuthGate letter-glitch backdrop with magic-link form](https://cursor.com/agents/bc-d9570e0c-a76a-45c7-b89f-a398562d5dab/artifacts?path=%2Fopt%2Fcursor%2Fartifacts%2Fauthgate_letter_glitch.png) [authgate_letter_glitch_walkthrough.mp4](https://cursor.com/agents/bc-d9570e0c-a76a-45c7-b89f-a398562d5dab/artifacts?path=%2Fopt%2Fcursor%2Fartifacts%2Fauthgate_letter_glitch_walkthrough.mp4) <sub>To show artifacts inline, <a href="https://cursor.com/dashboard/cloud-agents#my-pull-requests">enable</a> in settings.</sub> <!-- CURSOR_AGENT_PR_BODY_END --> <div><a href="https://cursor.com/agents/bc-d9570e0c-a76a-45c7-b89f-a398562d5dab?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-d9570e0c-a76a-45c7-b89f-a398562d5dab&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
![https://cursor.com/assets/images/open-in-web-dark.png"><source](https://cursor.com/assets/images/open-in-web-dark.png"><source){kind=link}
![https://cursor.com/assets/images/open-in-web-light.png"><img](https://cursor.com/assets/images/open-in-web-light.png"><img){kind=link}
![https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a](https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a){kind=link}
![https://cursor.com/assets/images/open-in-cursor-dark.png"><source](https://cursor.com/assets/images/open-in-cursor-dark.png"><source){kind=link}
![https://cursor.com/assets/images/open-in-cursor-light.png"><img](https://cursor.com/assets/images/open-in-cursor-light.png"><img){kind=link}
![https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div](https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linux AppImage QA on v0.21.0 saw a solid
#0a0b0dmain window: AuthGate’s magic-link form was covered by an opaque LoginBackdrop canvas, and Settings → Account Sign In did not surface a readable email field.z-index1 vs 0).--bg-base; stroke the corridor only so a compositor miss cannot hide the form.--glass-bg-fallbackon the card and drop full-window-webkit-app-region: drag.document.body, drop overlaybackdrop-filter, and paint the dialog on--glass-bg-fallback.No guest path. No continue-locally skip.
OFFICIAL_THEMESstays[]. No package.json bump, tag, Capture, or GitHub OAuth changes.Type of Change
Related Issues
QA fail on shipping Dripnex v0.21.0 AppImage (AuthGate does not paint).
Checklist
pnpm test)pnpm --filter @dripnex/desktop build)developbranch (notmain)Screenshots
Unauthenticated main window (email field + magic-link action on LoginBackdrop):
AuthGate email form above LoginBackdrop tunnel
Settings → Account → Sign In (email + Send Magic Link):
Settings Account Sign In magic-link dialog
To show artifacts inline, enable in settings.