fix: Inconsistent SQL Migration Files Processing Across Different Operating Systems #4331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the
readMigrationFiles
function, the generated SQL arrays differ between Windows and macOS/Linux environments due to different line ending conventions.Current Behavior
The
readMigrationFiles
function reads SQL files and splits them at statement breakpoints. However, it preserves the native line endings:\r\n
(CRLF)\n
(LF)This causes inconsistency in the resulting SQL arrays:
On macOS:
On Windows:
Expected Behavior
The function should produce consistent SQL arrays regardless of the operating system where it runs.
Proposed Solution
Normalize line endings when reading SQL files:
This simple change ensures consistent behavior across all platforms.
readMigrationFiles
(drizzle-orm/migrator) Inconsistent SQL Migration Files Processing Across Different Operating Systems #4329