Fix error when executing SQL through string_view without null terminator #2329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordMZTE
suggested changes
Jun 4, 2025
There was a problem hiding this comment.
I think we unfortunately can't check if there is a null byte; we probably have to store whether there is one or not once we get the SQL from the user. In case the user gives us a std::string_view, we can probably assume that there is none, if we get a char* we can assume there is.
| client_(client), | ||
| type_(type) | ||
| { | ||
| if (sql[sqlLength] != '\0') |
There was a problem hiding this comment.
I don't think this is sound; if sql ends at a page boundary, the access of sql[sqlLength] would be out-of-bounds and could cause a segfault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix #2328