Update embedded-tls version to 0.19.0#137
Conversation
also update the mbedtls-rs repo url
|
Hey, I don't know what your process is for this project and if you accept reviews from non maintainer but since I would be interested in seeing this being merged, here are my inputs on the failing I tried to run it locally and realized that it actually tries to connected to an hardcoded Google IP and this times out. AFAIK Google frontends are anycast and their IP to service mapping changes by region and over time, so a fixed IP can stop answering for some users or networks at any moment. Resolving the address at runtime will fix this. I fixed it locally with this small change in - let google_ip = [142, 250, 74, 110];
- let addr = SocketAddr::from((google_ip, 80));
+ let addr: SocketAddr = tokio::net::lookup_host("www.google.com:80")
+ .await
+ .expect("DNS Resolution of www.google.com should work")
+ .find(|address| address.is_ipv4())
+ .expect("www.google.com DNS resolution should return at least one IPV4 address"); |
|
@ElouanPetereau Thanks for the suggestion, just pushed a fix (wanted to add you as co-author but I'm not sure how to reference your account manually). |
No need, I am glad if I could be of any help. I hope the project maintainer will have some time to review this soon :) |
Also:
google_panictest as per @ElouanPetereau suggestionCloses #134