Skip to content

Update embedded-tls version to 0.19.0#137

Merged
lulf merged 2 commits into
drogue-iot:mainfrom
alloncm:embedded-tls-19
Jun 15, 2026
Merged

Update embedded-tls version to 0.19.0#137
lulf merged 2 commits into
drogue-iot:mainfrom
alloncm:embedded-tls-19

Conversation

@alloncm

@alloncm alloncm commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Also:

  • Fix google_panic test as per @ElouanPetereau suggestion
  • Update the mbedtls-rs repo url

Closes #134

also update the mbedtls-rs repo url
@ElouanPetereau

Copy link
Copy Markdown

Hey,

I don't know what your process is for this project and if you accept reviews from non maintainer but since I would be interested in seeing this being merged, here are my inputs on the failing google_panic unit test.

I tried to run it locally and realized that it actually tries to connected to an hardcoded Google IP and this times out. AFAIK Google frontends are anycast and their IP to service mapping changes by region and over time, so a fixed IP can stop answering for some users or networks at any moment.

Resolving the address at runtime will fix this. I fixed it locally with this small change in tests/request.rs:

-    let google_ip = [142, 250, 74, 110];
-    let addr = SocketAddr::from((google_ip, 80));
+    let addr: SocketAddr = tokio::net::lookup_host("www.google.com:80")
+        .await
+        .expect("DNS Resolution of www.google.com should work")
+        .find(|address| address.is_ipv4())
+        .expect("www.google.com DNS resolution should return at least one IPV4 address");

@alloncm

alloncm commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

@ElouanPetereau Thanks for the suggestion, just pushed a fix (wanted to add you as co-author but I'm not sure how to reference your account manually).

@ElouanPetereau

Copy link
Copy Markdown

@ElouanPetereau Thanks for the suggestion, just pushed a fix (wanted to add you as co-author but I'm not sure how to reference your account manually).

No need, I am glad if I could be of any help.

I hope the project maintainer will have some time to review this soon :)

@lulf lulf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lulf lulf merged commit 69db796 into drogue-iot:main Jun 15, 2026
1 check passed
@alloncm alloncm deleted the embedded-tls-19 branch June 15, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version 0.14.0 does not compile out of the box

3 participants