Skip to content

Commands refactoring rfc#21

Open
dejanb wants to merge 1 commit intomainfrom
commands
Open

Commands refactoring rfc#21
dejanb wants to merge 1 commit intomainfrom
commands

Conversation

@dejanb
Copy link
Copy Markdown
Member

@dejanb dejanb commented Nov 9, 2022

No description provided.

@dejanb dejanb requested review from ctron and lulf November 9, 2022 11:56
Copy link
Copy Markdown
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Maybe mention how this affects/deprecates earlier RFCs?

Copy link
Copy Markdown
Member

@ctron ctron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess what might make sense is to draft an OpenAPI spec of the new (internal) API for the service.

@dejanb
Copy link
Copy Markdown
Member Author

dejanb commented Nov 9, 2022

Nice work! Maybe mention how this affects/deprecates earlier RFCs?

I don't think we have any. There is no RFC for current implementation of commands.

@dejanb
Copy link
Copy Markdown
Member Author

dejanb commented Nov 9, 2022

I guess what might make sense is to draft an OpenAPI spec of the new (internal) API for the service.

Let's keep this one as draft for now. I would like to play with code first and then create API spec and more formal interaction diagrams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants