optimize alarm related

[yanhom1314]

No description provided.

[Copilot]

Pull Request Overview

This PR focuses on optimizing alarm-related functionalities across the codebase. Key changes include relocating the destroy method in AlarmManager, updating the filter order in SilentCheckFilter, and reducing the default alarm count threshold in NotifyItem.

Reviewed Changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
starter-extension-notify-email/.../NotifyEmailAutoConfiguration.java	Minor cleanup by removing an extra line.
core/notifier/manager/AlarmManager.java	Relocated the destroy() method to a new section in the file.
core/notifier/chain/invoker/AlarmInvoker.java	Removed unnecessary type casting for cleaner context access.
core/notifier/chain/filter/SilentCheckFilter.java	Updated getOrder() method and changed the AlarmLimiter API call.
core/notifier/chain/filter/BaseAlarmFilter.java	Refactored alarm count verification logic and renamed a parameter.
core/notifier/alarm/AlarmLimiter.java	Renamed ifAlarm() to isAllowed() for clarity.
core/notifier/alarm/AlarmCounter.java	Removed unused methods and repositioned getLastAlarmTime().
common/entity/NotifyItem.java	Lowered the default alarm count threshold from 2 to 1.
.github/workflows/build-jvmti.yml	Changed runner from ubuntu-20.04 to ubuntu-latest.

Files not reviewed (2)

• dependencies/pom.xml: Language not supported
• pom.xml: Language not supported

Comments suppressed due to low confidence (3)

core/src/main/java/org/dromara/dynamictp/core/notifier/chain/filter/SilentCheckFilter.java:45

• The filter order value has been changed from 2 to 5. Please verify that this adjustment aligns with the intended notification sequence and does not introduce ordering side effects.

return 5;

common/src/main/java/org/dromara/dynamictp/common/entity/NotifyItem.java:159

• The default alarm count threshold has been reduced from 2 to 1. Confirm that this change meets the intended alarm optimization requirements.

setIfZero(item::getCount, item::setCount, 1);

core/src/main/java/org/dromara/dynamictp/core/notifier/manager/AlarmManager.java:183

• The destroy() method has been relocated within the file. Please ensure that the new placement maintains the correct lifecycle management for the ALARM_EXECUTOR.

public static void destroy() {