Dynamic tp admin #582

EachannChan · 2025-08-18T02:43:33Z

No description provided.

…p-admin # Conflicts: # sdk/src/main/java/org/dromara/dynamictp/sdk/client/AdminClientUserProcessor.java # sdk/src/main/java/org/dromara/dynamictp/sdk/handler/refresher/AdminRefresher.java

yanhom1314 · 2025-08-19T14:06:35Z

common/src/main/java/org/dromara/dynamictp/common/entity/AdminRequestBody.java

+    public void serializeBody(Object object) {
+        HessianSerializer serializer = new HessianSerializer();
+        try {
+            this.body = serializer.serialize(object);


我理解common包里不需要引入sofa的包吧。序列化、反序列化应该是sofa框架内部做的，不需要我们自己做，这儿应该就是个简单的request bean

yanhom1314 · 2025-08-19T14:08:03Z

dependencies/pom.xml

+            <dependency>
+                <groupId>com.alipay.sofa.common</groupId>
+                <artifactId>sofa-common-tools</artifactId>
+                <version>${sofa-common-tools.version}</version>


sofa-common-tools 是不在sofa-bolt里引入了，需要单独引入吗

文档里说是得单独引入，然后admin端的话有报错，应该是手脚架的日志框架相关版本太高了，这个sofa-common-tools的太低了，到时还要解决一下

yanhom1314 · 2025-08-19T14:08:33Z

dependencies/pom.xml

+<!--                <artifactId>maven-gpg-plugin</artifactId>-->
+<!--                <version>1.6</version>-->
+<!--                <executions>-->
+<!--                    <execution>-->


pr里注释的这些恢复吧

yanhom1314 · 2025-08-19T14:10:14Z

example/pom.xml

+<!--        <module>example-adapter</module>-->
        <module>example-polaris-cloud</module>
        <module>example-huawei-cloud</module>
+<!--        <module>example-admin</module>-->


注释的恢复

yanhom1314 · 2025-08-19T14:11:08Z

sdk/pom.xml

+        <version>${revision}</version>
+        <relativePath>../pom.xml</relativePath>
+    </parent>
+    <artifactId>dynamic-tp-sdk</artifactId>


sdk module 改为 client吧，更规范点

yanhom1314 · 2025-08-19T14:14:48Z

sdk/src/main/java/org/dromara/dynamictp/sdk/client/AdminClient.java

+        AdminRequestBody requestBody = new AdminRequestBody(SNOWFLAKE_GENERATOR.next(), requestType);
+        Object object = null;
+        try {
+            client.invokeSync(connection, attributeRequestBody, 5000);


多写了一行？

这个是为了传attribute属性像是clientName过去给Admin端，本来是想通过Connection来传输的，但是Admin拿不到就用这种方式实现了。就相当于在每次请求时向admin更新attribute

没懂为啥要分两个请求呢，直接在AdminRequestBody里加上clientName字段不行吗。这看着很不合理

yanhom1314 · 2025-08-19T14:17:08Z

sdk/src/main/java/org/dromara/dynamictp/sdk/client/handler/collector/AdminCollector.java

+    public void collectAllPoolStats() {
+        try {
+            Set<String> executorNames = DtpRegistry.getAllExecutorNames();
+            if (executorNames.isEmpty()) {


参考DtpEndpoint ，adapter的指标也采集下。这个是不是用DtpMonitor定时采集上报更好点呢？

我实现下。这里应该是前端整了个定时刷新的机制，现在也有定时采集的

写个MetricsCollector，spi装载进去就行了

yanhom1314 · 2025-08-19T14:20:26Z

common/pom.xml

+        <dependency>
+            <groupId>com.alipay.sofa</groupId>
+            <artifactId>bolt</artifactId>
+        </dependency>


common 不要引入其他三方中间件依赖，保持common干净简洁

yanhom1314 · 2025-08-19T14:33:02Z

common/src/main/java/org/dromara/dynamictp/common/entity/AttributeRequestBody.java

+ * @author eachann
+ */
+public class AttributeRequestBody implements Serializable {
+


这个类好像存在的必要性不大啊，AdminRequestBody本身就是做请求体封装的

那我去掉吧

yanhom1314 · 2025-08-19T14:37:00Z

...ple/example-admin/src/main/java/org/dromara/dynamictp/example/controller/TestController.java

+@RestController
+@AllArgsConstructor
+public class TestController {
+


这个example好像就是复制了一份nacos的出来，并没有测试连接admin测试啊，可以优化下，不必要的删除下，配置admin的地址能正常跑起来。

yanhom1314 · 2025-08-19T14:59:36Z

sdk/src/main/java/org/dromara/dynamictp/sdk/client/AdminClient.java

+
+    private final int adminPort = 8989;
+
+    private final Url adminUrl = new Url(adminIp, adminPort);


client 怎么连接 admin 的地址，好像没看到配置的

client的地址是随机取的，这里配置不了。我把admin的端口暴露一下吧

…AttributeRequestBody

yanhom1314 · 2025-08-20T14:27:25Z

...n/java/org/dromara/dynamictp/starter/adapter/tars/autoconfigure/TarsTpAutoConfiguration.java

 @Configuration
 @AutoConfigureAfter({DtpBaseBeanConfiguration.class})
-@ConditionalOnClass(name = "com.qq.tars.client.Communicator")
+@ConditionalOnClass(name = "com.qq.tars.adminclient.Communicator")


多改了。。。

yanhom1314 · 2025-08-20T14:34:35Z

client/src/main/java/org/dromara/dynamictp/client/adminclient/AdminClient.java

 public class AdminClient {

-    private final String adminIp = "127.0.0.1";
+    @Value("${dynamictp.adminIp:127.0.0.1}")


这个是不得支持集群啊，多个ip，建立多个连接，搞个负载均衡策略拿连接

yanhom1314 · 2025-08-20T14:41:14Z

...t/src/main/java/org/dromara/dynamictp/client/adminclient/handler/refresh/AdminRefresher.java

 */

-package org.dromara.dynamictp.sdk.client.handler.refresh;
+package org.dromara.dynamictp.client.adminclient.handler.refresh;


adminclient，感觉这个包可以去掉

yanhom1314 · 2025-08-20T14:52:47Z

client/src/main/java/org/dromara/dynamictp/client/adminclient/AdminClient.java

        }
-        AttributeRequestBody attributeRequestBody = new AttributeRequestBody();
-        attributeRequestBody.setAttribute("clientName", clientName);
+        AdminRequestBody attributeRequestBody = new AdminRequestBody(SNOWFLAKE_GENERATOR.next(), AdminRequestTypeEnum.ATTRIBUTE);


如果必要，clientName 是不可以直接作为 AdminRequestBody 中的一个字段呢，单开一个map好像有点啰嗦

…n error handling

chenyc55879 and others added 17 commits July 7, 2025 08:10

add adminclient e.t.c

276ade5

add refresher related

116830a

refresh related

2b4eeec

add adminclient related and admin example

7444e29

Merge remote-tracking branch 'origin/dynamic-tp-admin' into dynamic-t…

46054dd

…p-admin # Conflicts: # sdk/src/main/java/org/dromara/dynamictp/sdk/client/AdminClientUserProcessor.java # sdk/src/main/java/org/dromara/dynamictp/sdk/handler/refresher/AdminRefresher.java

update

f9253af

update

2dc29c6

Admin config and dependency related

4b78375

handle monitor

31aada8

update

037e36b

complete c/s trans

63445a3

cpmlete tp metric logic and rebuild c/s connnect logic

93d8423

muti client rebuild and threadpool manage

f46035a

add Register pt logic

723f185

format

f0a8308

add client heatbeat logic

39b13aa

Merge branch 'dromara:master' into dynamic-tp-admin

d597046

yanhom1314 reviewed Aug 19, 2025

View reviewed changes

fix,add example test,optimize AdminCollector AdminRequestBody and rm …

97c9df9

…AttributeRequestBody

yanhom1314 reviewed Aug 20, 2025

View reviewed changes

EachannChan added 5 commits August 21, 2025 11:41

optimize client structure

bf379ac

complete cluster logic

1e03e24

optimize client structure

9160bf4

refactor AdminClient initialization and same client service connectio…

830aba6

…n error handling

send health message to server while ensure connection

6da1f09

EachannChan changed the base branch from master to dev October 18, 2025 11:14

yanhom1314 approved these changes Oct 19, 2025

View reviewed changes

yanhom1314 merged commit 7f0ec8f into dromara:dev Oct 19, 2025
1 check passed


		private final int adminPort = 8989;

		private final Url adminUrl = new Url(adminIp, adminPort);

Dynamic tp admin #582

Dynamic tp admin #582

Uh oh!

Conversation

EachannChan commented Aug 18, 2025

Uh oh!

yanhom1314 Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yanhom1314 Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yanhom1314 Aug 19, 2025 •

edited

Loading

yanhom1314 Aug 20, 2025 •

edited

Loading