Add heater control parameters to TunerStudio#32
Merged
Conversation
Owner
|
|
Author
Well, if we decide to make more timeouts user-configurable, like |
Author
|
I've also played around with making these values variable bit-width, so that we could store, for example, three |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved some heater parameters into config memory.
Specifically
HeaterSupplyOffVoltageHeaterSupplyOnVoltagePreheatTimeSecThis way the board could be configured to work independently of the ECU, so that
HeaterSupplyOnVoltagehigher than ~13.5VPreheatTimeSecto 5-10 minutes to allow engine to warm up a bit, and water condensation to evaporate.To conserve the precious RAM,
ScaledValuestruct is introduces, that allows seamlessly mapping int/uint values.This way values could be mapped to integers, scaling them both up and down.
12.5could be mapped to125in memory, if more precision is needed.Added unit tests for
ScaledValue, so that it definitely fits into its storage typeAnd unit tests for Configuration, to make sure changes to config structure would be backward-compatible with existing units.