Skip to content

Fix Hetzner 404 error detection during server destruction #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cvetkovski98 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Hetzner 404 error detection during server destruction #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drivers/hetznercloud/destroy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ func (p *provider) Destroy(ctx context.Context, instance *autoscaler.Instance) e
_, err = p.client.Server.Delete(ctx, &hcloud.Server{ID: id})

if err != nil {
if err.Error() == "hcloud: server responded with status code 404" {
if hcloud.IsError(err, hcloud.ErrorCodeNotFound) {
logger.WithError(err).
Debugln("instance does not exist")
return autoscaler.ErrInstanceNotFound
Expand Down
1 change: 1 addition & 0 deletions drivers/hetznercloud/destroy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ func TestDestroyNotFound(t *testing.T) {
gock.New("https://api.hetzner.cloud").
Delete("/v1/servers/3164494").
Reply(404).
SetHeader("Content-Type", "application/json").
BodyString(destroyNotFoundResponse)

mockContext := context.TODO()
Expand Down