feat: [CI-16330]: Adding default OutputFile as DRONE_OUTPUT. #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ompragash
reviewed
Feb 24, 2025
There was a problem hiding this comment.
@DevanshMathur19 can you attach a link to the test execution where the updated change is tested and the digest is exported as output var?
Ompragash
reviewed
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execution Links for Kaniko-ecr:
Cloud: https://app.harness.io/ng/account/gCoPSwHxS7ipOgx2iA9tOQ/all/orgs/default/projects/devanshci/pipelines/kanikoecr/executions/dWsqGal1Qku6LxiYZuXRDA/pipeline?storeType=INLINE&step=5xolfedFTiul47eQWLXsVQ&stage=6kD1Q5xEQISQLi__2CuLiw&childStage=&stageExecId=
K8:https://qa.harness.io/ng/account/h61p38AZSV6MzEkpWWBtew/all/orgs/default/projects/Devansh_Test/pipelines/kanikoecrtest/executions/nM7k6O0fQwOIlgTqNrccZg/pipeline?step=Ls8YdXqJRLqiNcHZgTvPPg&stage=2W7tg7EsSyyt3_4hutHkdA&childStage=&stageExecId=
execution link for kaniko base image in plugin step(Only the 2nd parallel step): https://qa.harness.io/ng/account/h61p38AZSV6MzEkpWWBtew/all/orgs/default/projects/D[…]oD-opcEg&stage=Q1EOchtCTD6DmImmvMyQHQ&childStage=&stageExecId=
•Tested Kaniko base image in the plugin step, and it provided the digest in output variables.
•Unable to test in the OOTB step because images were still being pulled through Buildx, even after updating them via API.
•Attempted to disable a feature flag in Harness0 to stop Buildx from pulling images, but it continued to do so.
•Tried testing locally but encountered an error previously found by Abhay; attempts to fix it were unsuccessful.
•Since the images worked in the plugin step, they should be backward compatible and not cause any issues.