Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [PIPE-23883]: defined cgiTaskResponse, fix NPE error when pipeline execution and secret fetching fails #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: [PIPE-23883]: defined cgiTaskResponse, fix NPE error when pipeline execution and secret fetching fails #21

wants to merge 1 commit into from

Conversation

xingchi-jin
Copy link
Contributor

  1. Fix the NPE error when fetching secret fails during local_execute task.
  2. Defined CGITaskResponse type, so that it will be the standard CGI task response data structure. Using the status_code in it we can identify whether secret fetch succeeded or not.

rohitk-h
rohitk-h reviewed Feb 28, 2025
View reviewed changes
task/router.go

// attempt to unmarshal the task response
// body into the secrets struct.
out := new(common.Secret)
if err := json.Unmarshal(res.Body(), &out); err != nil {
//out := new(common.Secret)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitk-h rohitk-h rohitk-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xingchi-jin @rohitk-h