Claude/analyze codebase ekb1m - #10
Merged
Merged
Conversation
Change TelloSource.__init__ to check `Tello is None` instead of `not TELLO_AVAILABLE`. This resolves a CI-specific failure where the class-level @patch("src.tello_source.TELLO_AVAILABLE", True) decorator wasn't consistently applying before the first test method ran (test_commands_disabled_by_config, alphabetically first). The new check works naturally with @patch("src.tello_source.Tello") since the mock replaces Tello with a MagicMock (not None), so the guard passes without needing a separate TELLO_AVAILABLE patch. Removed all @patch("src.tello_source.TELLO_AVAILABLE", True) decorators from tests that already patch Tello. Updated test_creation_without_djitellopy to patch Tello to None instead. https://claude.ai/code/session_012XY2M4e4QuJnMcVhA2Zicx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.