Add --output=json support to account and du commands - #273
Merged
Conversation
Migrate account and du to emit structured JSON. Add usersClient interface and factory for testability. Account outputs full/basic account metadata; du outputs usage and allocation details including team space fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
accountandduto emit structured JSON when--output=jsonis usedusersClientinterface andusersNewFuncfactory for testability (same pattern asfilesNewFunc)accountoutputs full/basic account metadata with name, email, team infoduoutputs usage and allocation details (individual + team with space limit fields)io.Writerinstead ofos.StdoutrenderBasicAccountno longer mutates the inputBasicAccount.EmailfieldTest plan
go vet ./...cleangolangci-lint run ./...cleango test ./... -count=1)dbxcli account --output=jsonemits JSON with full account metadatadbxcli account --output=json <account-id>emits JSON with basic account lookupdbxcli du --output=jsonemits JSON with usage and allocationdbxcli accountanddbxcli dutext output unchanged