Skip to content

Conversation

@drumath2237
Copy link
Owner

No description provided.

@drumath2237
Copy link
Owner Author

/gemini summary

@gemini-code-assist
Copy link

Summary of Changes

This pull request refines the package distribution by excluding the templates directory from the published npm package. This likely aims to reduce the package size or remove unnecessary files from the final distribution.

Highlights

  • Build Configuration: The templates directory has been removed from the files array within package.json. This change ensures that the templates folder will no longer be included when the package is published to npm.
Changelog
  • package.json
    • Removed the entry for templates from the files array, which dictates which files are included in the npm package.
Activity

@drumath2237
Copy link
Owner Author

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request proposes removing the templates directory from the list of files published to npm. Based on my analysis of the repository's structure and code, this change appears to be critical. The command-line tool seems to depend on the files within the templates directory at runtime to perform its core function of scaffolding new projects. Removing this directory from the published package would likely break the tool for end-users. My review comment highlights this critical issue and asks the author for clarification.

@drumath2237
Copy link
Owner Author

@gemini-code-assist this is safe. now, this tool pulls templates from githun url at runtime and dont depend with templates/ directory in npm

@gemini-code-assist
Copy link

Thanks for the clarification, @drumath2237! That context is very helpful and confirms the change to exclude the templates/ directory from the npm package is indeed intentional and safe, given the runtime fetching of templates from a GitHub URL.

@drumath2237
Copy link
Owner Author

@gemini-code-assist can you approve this pr?

@gemini-code-assist
Copy link

Thanks for asking, @drumath2237! As gemini-code-assist, I'm an AI assistant designed to provide code review feedback and summaries. I'm not able to directly approve pull requests or perform other administrative actions on the platform. That action needs to be taken by a human reviewer with the appropriate permissions.

@drumath2237
Copy link
Owner Author

@gemini-code-assist ok, isee

@gemini-code-assist
Copy link

It looks like you've acknowledged the previous message. Is there anything else I can assist you with regarding this pull request, such as providing a review or a summary?

@drumath2237 drumath2237 moved this from 🆕 New to 🏗 In progress in create-babylon-app Development Jul 3, 2025
@drumath2237 drumath2237 added this to the v1.1.0 milestone Jul 3, 2025
@drumath2237 drumath2237 linked an issue Jul 3, 2025 that may be closed by this pull request
@drumath2237 drumath2237 merged commit d90402f into main Jul 3, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in create-babylon-app Development Jul 3, 2025
@drumath2237 drumath2237 deleted the feature/#71-remove-templates-folder-from-files branch July 3, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

remove templates/ folder from files

1 participant