-
-
Notifications
You must be signed in to change notification settings - Fork 2
remove templates/ folder from files
#76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove templates/ folder from files
#76
Conversation
|
/gemini summary |
Summary of ChangesThis pull request refines the package distribution by excluding the Highlights
Changelog
Activity
|
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request proposes removing the templates directory from the list of files published to npm. Based on my analysis of the repository's structure and code, this change appears to be critical. The command-line tool seems to depend on the files within the templates directory at runtime to perform its core function of scaffolding new projects. Removing this directory from the published package would likely break the tool for end-users. My review comment highlights this critical issue and asks the author for clarification.
|
@gemini-code-assist this is safe. now, this tool pulls templates from githun url at runtime and dont depend with |
|
Thanks for the clarification, @drumath2237! That context is very helpful and confirms the change to exclude the |
|
@gemini-code-assist can you approve this pr? |
|
Thanks for asking, @drumath2237! As |
|
@gemini-code-assist ok, isee |
|
It looks like you've acknowledged the previous message. Is there anything else I can assist you with regarding this pull request, such as providing a review or a summary? |
No description provided.