Guard against missing PDO MySQL constants#6464
Open
RobXYZ wants to merge 1 commit intodrush-ops:13.xfrom
Open
Conversation
SqlBase::create() swallowed and returned null, so the validator thought no driver existed
Member
|
Whats your PHP version? |
Author
|
PHP 8.3.27 |
Member
|
I'm not sure that its valid for those constants to be missing. Your mPDO would be busted. Anyway, here is how Drupal core handled this, in case anyone wants to make a different PR. I would merge that approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found commands like sql:drop starting throwing errors after updating from 13.6.2 to 13.7 on my web host.
Error: Call to a member function command() on null in Drush\Commands\sql\SqlCommands->validate() (line 244 of /drush/drush/src/Commands/sql/SqlCommands.php).This seems to be due to undefined PDO::MYSQL_ATTR_* constants. SqlBase::create() swallowed and returned null.
Codex found and wrote this fix so it may not be correct but hopefully points in the right direction.