Open
Conversation
weitzman
reviewed
Jan 6, 2026
Comment on lines
499
to
500
| assert($this->logger instanceof SuccessInterface); | ||
| $this->logger->success( |
Member
There was a problem hiding this comment.
Shouldnt we use io when we use success()? Thats what fieldDelete is doing ... Oh, its because we should a hyperlink later. I would rather give up the hyperlink than make success() usage inconsistent. or lets fix io so it can print hyperlinks.
Contributor
Author
There was a problem hiding this comment.
Member
|
I'm OK with using logger in 13.x, but 14.x can't use logger. We want to support injecting a plain PSR logger and that doesnt have success(). |
Member
|
Feel free to emit a regular link (i.e. not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for an issue discussed in #6481.