skip checks for branch deletions#73
Open
brianlong2 wants to merge 2 commits into
Open
Conversation
Owner
|
Sorry, a nasty bout of illness has had me offline for a few days. I like this PR overall, but I think we should add some logic around the "rm -rf" to ensure we're not somehow accidentally rm-ing /. |
| # workaround: deleting a branch should skip the checks | ||
| if [[ $newrev == "0000000000000000000000000000000000000000" ]]; then | ||
| echo "Skipping file checks this is a branch delete..." | ||
| rm -rf "$tmptree" |
Collaborator
There was a problem hiding this comment.
@brianlong2 It would be much safer to use rmdir instead of rm. With this we avoid problems mentioned by David in comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #71