Fix keyword argument forwarding in Initializer module#93
Open
bolshakov wants to merge 1 commit intodry-rb:mainfrom
Open
Fix keyword argument forwarding in Initializer module#93bolshakov wants to merge 1 commit intodry-rb:mainfrom
bolshakov wants to merge 1 commit intodry-rb:mainfrom
Conversation
The `Initializer` module's `initialize` method only captured positional arguments (`*args`), causing it to fail when containers were initialized with keyword arguments:
```ruby
class MyContainer
include Dry::Container::Mixin
def initialize(config:, data_store:)
# ...
end
end
MyContainer.new(config: cfg, data_store: ds)
```
I updated `Initializer#initialize` to explicitly capture and forward keyword arguments using `**kwargs`:
```ruby
def initialize(*args, **kwargs, &block)
@_container = ::Concurrent::Hash.new
super
end
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Initializermodule'sinitializemethod only captured positional arguments (*args), causing it to fail when containers were initialized with keyword arguments:I updated
Initializer#initializeto explicitly capture and forward keyword arguments using**kwargs: