Introduce part operation#37
Open
hwo411 wants to merge 1 commit into
Open
Conversation
* Valid when at least one rule is valid * Returns AST with all errors in case no rules are valid * Add visit_set and visit_part to Result
Member
|
I'd say |
Contributor
Author
|
@solnic Initially I was thinking about |
Contributor
Author
|
@solnic Just after some thinking, we can imagine 2 different groups of operations:
By shortcut I mean applying 2 rules via 1 method/class without creating new kind of operation and new type of ast. WDYT? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the changes I mentioned in:
https://discourse.dry-rb.org/t/extensions-for-dry-logic-and-dry-validations-to-support-open-api-schemas/525
I have 2 questions about the implementation:
partgood?Result::SUCCESSor should I put successful or failed rules into successful result?