Skip transform_values when dealing with a Dry::Struct#202
Merged
Conversation
timriley
approved these changes
Feb 28, 2026
Member
timriley
left a comment
timriley
left a comment
There was a problem hiding this comment.
Thanks @katafrakt! Looks good, let's merge this in. Please add a CHANGELOG entry, I'll cut a patch release soon :)
This brings performance improvements of around 1.4-1.9x according to my benchmarks. `Hashify.[]` is already part of the implementation of `.to_h` for a `Dry::Struct`. Also makes it explocit that we are checking here for a `Dry::Struct`, not a `Struct` from stdlib.
katafrakt
force-pushed
the
improve-dry-struct-hashifying
branch
from
8c34d08 to
7425fd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings performance improvements of around 1.4-1.9x according to my benchmarks.
Hashify.[]is already part of the implementation of.to_hfor aDry::Struct. Fixes #200. I used an example from that ticket for benchmarks.Also makes it explicit that we are checking here for a
Dry::Struct, not aStructfrom stdlib. And fixes the YARD doc.