ManifestRegistrar uses load instead of require#286
Merged
timriley merged 1 commit intodry-rb:mainfrom Jul 29, 2025
Merged
Conversation
This is a bug that is caused by the interaction between dry-system and dry-rails. Dry::Rails rebuilds the Container from scratch on every reload, which resets all the keys. Since ManifestRegistrar was using `require`, this reload would not register the keys as expected.
Member
|
@alassek Nice work, thank you for hunting this down! And bonus points for "simulacrum" ;) I'll merge this now and cut a patch release. |
Member
|
Released as 1.2.3! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bug that is caused by the interaction between dry-system and dry-rails.
Dry::Rails rebuilds the Container from scratch on every reload, which resets all the keys. Since ManifestRegistrar was using
require, this reload would not register the keys as expected.