Fix lazy loading of imported components - #287
Merged
Merged
Conversation
|
Instead of adapting the check, how about updating the storage ( |
timriley
force-pushed
the
fix-lazy-loading-imported-keys
branch
from
August 14, 2025 11:45
3b92e3c to
252eb21
Compare
Member
Author
|
@unused thank you for checking this out! :D I agree, that's a much better approach. I've just pushed that up in the last commit here. I'll merge this now and cut a patch release. |
timriley
force-pushed
the
fix-lazy-loading-imported-keys
branch
from
August 14, 2025 11:47
252eb21 to
2b8646d
Compare
Member
Author
|
Released in 1.2.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were checking for an import namespace using a component
root_key, which is a symbol, whereas the importer was expecting strings. This led to imported components only becoming available on a full boot, not when lazy loading properly (because the check for their namespace in the importer would always return false due to the type mismatch).This will resolve hanami/hanami#1529.