Remove different error messages for JRuby in test expectations - #291
Merged
Conversation
I think in the past JRuby generated a different error message on missing files. Now with 10.0.2.0 the messages are the same as with CRuby, so the special JRuby handling in tests is no longer necessary.
Contributor
|
ℹ️ Optional job failed: Ruby jruby |
timriley
approved these changes
Dec 3, 2025
timriley
left a comment
timriley
left a comment
Member
There was a problem hiding this comment.
We haven't had JRuby in CI for many years. This is some old test code! 🕸️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think in the past JRuby generated a different error message on missing files. Now with 10.0.2.0 the messages are the same as with CRuby, so the special JRuby handling in tests is no longer necessary.