Enable ObjectSpace in JRuby - #292
Merged
Merged
Conversation
It's disabled by default, but we need it for these specs.
Contributor
|
ℹ️ Optional job failed: Ruby jruby |
timriley
approved these changes
Dec 3, 2025
timriley
left a comment
timriley
left a comment
Member
There was a problem hiding this comment.
Thanks @katafrakt! I presume this is the first step of several to get the tests green?
Contributor
Author
|
@timriley yes! I personally favour the approach with quite atomic PRs (especially given that remaining failures are tricky and related to Zeitwerk, which tests does not pass on JRuby). But if you prefer bigger changes that fix all the failures in the future, I can adjust. |
Member
|
@katafrakt small PRs is great with me, just wanted to check I didn't miss anything :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's disabled by default, but we need it for these specs.