ManifestRegistrar#finalize! avoids duplicates - #295
Merged
Conversation
This resolves a subtlety introduced by the fix in #286 `Container#finalize!` processes providers first, before moving on to manifest registrations. If a class injects something defined by a manifest file, and this class is instantiated within a provider, this eager-loads the manifest key before `finalize!` reaches the ManifestRegistrar. Moving `ManifestRegistrar#call` to use `load` instead of `require` introduced the possibility of double-registering a key.
Contributor
Author
|
Rubocop failures are not related to this changeset. |
This avoids us having to iterate over the entire container.
Member
|
Thanks for picking this up, @alassek! I pushed a little tweak that I think should make it more efficient — how does that seem to you? |
Contributor
Author
|
@timriley that's a better solution, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a subtlety introduced by the fix in #286
Container#finalize!processes providers first, before moving on to manifest registrations.If a class injects something defined by a manifest file, and this class is instantiated within a provider, this eager-loads the manifest key before
finalize!reaches the ManifestRegistrar.Moving
ManifestRegistrar#callto useloadinstead ofrequireintroduced the possibility of double-registering a key.